Patch bridge anomaly - #1900
Open
BazzaCuda wants to merge 10 commits into
Open
Patch bridge anomaly#1900BazzaCuda wants to merge 10 commits into
BazzaCuda wants to merge 10 commits into
Conversation
Author
|
p.s. this issue also prevents array_trim from properly trimming the array as array_trim stops when it hits the most recent "in use" element. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After deleting a bridge, a phantom array element with state=BUILDING_STATE_IN_USE exists in the buildings array, even though the bridge is no longer displayed. Furthermore, the "building" with the bridge's grid_offset is now the grass tile, not the bridge.
This results in an incorrect building count, inflated by however many bridges have been deleted.
This patches the problem.