Repository navigation
fix(notifications): 自审 A 组——「查看」走挂起定位、对话框上 / 没铃铛时不开历史、折叠去重露出、清空连带折叠卡、读屏与铃铛语义、系统提示音、历史时间刷新 - #293
Merged
Merged
Conversation
…读屏与铃铛语义、系统提示音归系统音量、历史时间刷新 - 通知卡「查看」改走 canvasFocusRequestProvider:原先切画布同一刻直接写选中,目标画布没挂载时被 autoDispose 回收(#289 漏掉的入口);那条测试人为订阅保活、同步读值,一直是绿的,改成断言请求。 - ToastCenterState.historyHostReady:铃铛按自己所在路由是否在最上层上报。上面压着对话框时历史面板会 画在遮罩底下、还抢走对话框焦点;启动失败页没有铃铛,开了历史就关不掉——这两种时候「还有 N 条」 不可点、开着的历史立即关。 - 去重替换到一张被折叠的卡:挪到最新位置露出来(正在显示的仍原地换)。 - 清空历史连带折叠的卡;折叠着的进度卡与它那一行历史照留。 - 失败卡原地换成新的失败也重新播报;铃铛语义标签带上未读 / 未读失败。 - Windows 系统提示音加 SND_SYSTEM,归到系统声音的音量会话。 - 历史面板开着时每 30 秒刷新相对时间。 - docs:notification_sound 目录、ffi 依赖、job_notification_listener 的描述改准。 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
画布重设计这一轮(#280–#292)合完后,我派了三路只读审查代理对改动做了一次自审。这个 PR 修的是 A 组:通知、提示音、主题层,审查结果是 2 条中危、8 条低危。每条都按当前代码复核过,只有一条低危不修。
修了什么
中危
canvasFocusRequestProvider。原来那条测试先人为订阅保活、再同步读值,所以一直是绿的,什么都没守住。现在改成断言请求本身。historyHostReady,由铃铛按「自己所在的路由是否在最上层」上报。承接不了时,胶囊不可点;已经开着的历史会立即关掉。低危
SND_SYSTEM,归到「系统声音」音量会话,音量合成器里调系统声音对它生效。不修:音频播放器里那几处宽泛的 catch。仓库里有同样的先例,注释写了理由,现有测试也是按这个行为写的。
验证
flutter analyze lib test:无问题。flutter test --exclude-tags golden:3293 通过,0 失败。SND_SYSTEM是平台 FFI 调用,没有单测,只改了一个标志位。自审修复 1 / 4。
🤖 Generated with Claude Code