Repository navigation
fix(canvas): 自审 C4 / C5——提示词条让开左下缩放条、产物落点取第一个空格 - #294
Merged
Merged
Conversation
- 提示词条居中会压到左下那一簇(缩放条 + 泳道工具栏)时,改在右边那段里居中、放不下再收窄:窗宽 1280、左右栏都开时原来「适应」「+」整格被盖住。新令牌 InkToolbarSize.stageBottomLeftReserve,外壳 布局测试守着两条的右沿都落在预留宽度里。 - 产物落点取这一列第一个空着的格(nextResultSlot),不再按现存数量:删掉中间一张后,下一个产物原来 正好叠在最后一张上。被拖离格位的产物不占格。 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
画布重设计合完后做了自审,这个 PR 修其中 C 组的两条布局 / 落点问题。
修了什么
C4 提示词条盖住左下缩放条
InkToolbarSize.stageBottomLeftReserve(176),表示这一簇占的宽度。外壳布局测试会守着两条控件的右沿加间隙都落在这个宽度以内:以后谁改了缩放条或泳道工具栏的宽度,这条测试会提醒同步调整令牌。C5 删掉中间的产物后,新产物叠在最后一张上
nextResultSlot,取这一列里第一个空着的格。判断是否占格时容差 1px;被用户拖离格位的产物不算占格。验证
flutter analyze lib test:无问题。flutter test --exclude-tags golden:3293 通过,0 失败。「适应全部」底部让出提示词条的改动要动
canvas_tool_actions.dart,这个文件另一个修复 PR 正在改,等它合并后再做。自审修复 2 / 4。
🤖 Generated with Claude Code