Skip to content

Keychron C3 Pro RGB: fix EEPROM overlap, factory test keys, and adaptive NKRO/RGB/OS toggle bugs - #536

Open
akryvtsun wants to merge 7 commits into
Keychron:2025q3from
akryvtsun:kontiky_keyboard
Open

akryvtsun wants to merge 7 commits into
Keychron:2025q3from
akryvtsun:kontiky_keyboard

Conversation

@akryvtsun

@akryvtsun akryvtsun commented Nov 10, 2026 •

Copy link
Copy Markdown

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Language and Snap Click settings overlapped VIA's EEPROM data, so changing the language could wipe the keymap.
  • Fn+J+Z factory reset and the Fn+Home+Right backlight test never triggered on C3 Pro.
  • Adaptive NKRO key counters drifted after clear_keyboard(), leaving a 6-key limit until replug.
  • set_suppressed_override_mods() set the wrong variables, so the report wasn't flagged as changed.
  • One-shot mod changes didn't flag the report under adaptive NKRO.
  • Factory test version string and device ID, raw HID fall-through, VIA RGB save, #pragma error, duplicate suspend call, OS toggle, Digital Rain brightness scaling.
  • Version: ANSI RGB build now reports 1.0.2; other C3 Pro variants stay at 1.0.1.

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants