Repository navigation
Conversation
A mod-tap set from Launcher or VIA with several modifiers, such as MT(MOD_MEH, KC_CAPS), held only the lowest one. MEH sent Ctrl alone. mod_to_zmk_keycode() returned the keycode of the first modifier bit it found and dropped the rest. Its uint8_t return type could not carry modifier flags either. Return the first modifier's keycode with the remaining modifiers in the top byte, the same encoding as LC(LS(LALT)). ZMK treats those as explicit modifiers when the keycode is itself a modifier, so all of them are held. Tested on a B6 Pro ANSI (PID 0x076B, keychron_b6_usn). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A mod-tap set from Launcher or VIA with several modifiers, such as MT(MOD_MEH, KC_CAPS), held only the lowest one. MEH sent Ctrl alone.
mod_to_zmk_keycode() returned the keycode of the first modifier bit it found and dropped the rest. Its uint8_t return type could not carry modifier flags either.
Return the first modifier's keycode with the remaining modifiers in the top byte, the same encoding as LC(LS(LALT)). ZMK treats those as explicit modifiers when the keycode is itself a modifier, so all of them are held.
Tested on a B6 Pro ANSI (PID 0x076B, keychron_b6_usn).
PR check-list