Remove block math from ArticleRenderer regression story - #4098
Open
benchristel wants to merge 2 commits into
Open
benchristel wants to merge 2 commits into
benchristel wants to merge 2 commits into
Conversation
Contributor
|
Size Change: 0 B Total Size: 519 kB ℹ️ View Unchanged
|
Contributor
npm SnapshotWant to try this PR's changes before it merges? Comment |
Myranae
reviewed
Aug 20, 2026
Comment on lines
-234
to
-241
| $\\begin{aligned} | ||
| 2y+\\redD{7x} &= -5 \\\\ | ||
| +~5y\\redD{-7x}&=12\\\\ | ||
| \\hline\\\\ | ||
| 7y+0 &=7 | ||
| \\end{aligned}$ | ||
|
|
||
| This is a paragraph after the block math. |
Contributor
There was a problem hiding this comment.
The only thing with color sync is that we have not finished the paragraph refactor, so we need coverage of all the things for when we flip that flag. Are there other stories that cover block math?
Member
Author
There was a problem hiding this comment.
Hmm, good point. I don't think we have any other coverage for block math.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This visual snapshot test was flaky, I think because of a race condition
involving math layout. Since we've already deployed our article changes for the
Color Sync project, I think the risk of a regression specific to block math is
low, and not worth the annoyance of maintaining this flaky test.
Issue: none
Test plan:
CI should pass once the change to the snapshot is manually approved.