Skip to content

Force size 0 allocations to be size 1 allocations to avoid misreporting OOM #2086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aitor-lunarg wants to merge 1 commit into from
Closed

Force size 0 allocations to be size 1 allocations to avoid misreporting OOM #2086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions loader/allocation.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@

void *loader_calloc(const VkAllocationCallbacks *pAllocator, size_t size, VkSystemAllocationScope allocation_scope) {
void *pMemory = NULL;

// Requesting a size 0 allocation to either calloc or custom Vulkan allocators is unspecified. This means we could get NULL as
// the return value, which can end up as an OOM error from the loader when execution can continue without issues.
if (size == 0) size = 1;

#if (DEBUG_DISABLE_APP_ALLOCATORS == 1)
{
#else
Expand Down
Loading