Repository navigation
Fix ninja build on windows - #2088
Merged
charles-lunarg merged 1 commit intoOct 28, 2026
Merged
Conversation
The generator expression contained an extra colon, which causes only the C source files to get the desired expression. And because detours & gtest do not enable /guard:ehcont on their own, we have to enable it for them so that everything has it enabled in order to make the linker happy.
|
CI Vulkan-Loader build queued with queue ID 174304. |
|
CI Vulkan-Loader build queued with queue ID 174321. |
|
CI Vulkan-Loader build # 3926 running. |
|
CI Vulkan-Loader build # 3926 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generator expression contained an extra colon, which causes only the C source files to get the desired expression.
And because detours & gtest do not enable /guard:ehcont on their own, we have to enable it for them so that everything has it enabled in order to make the linker happy.