Skip to content

Fix/docx latin line spacing 510 - #1125

Closed
mohamedelghazali wants to merge 5 commits into
KnifeLemon:mainfrom
mohamedelghazali:fix/docx-latin-line-spacing-510
Closed

mohamedelghazali wants to merge 5 commits into
KnifeLemon:mainfrom
mohamedelghazali:fix/docx-latin-line-spacing-510

Conversation

@mohamedelghazali

@mohamedelghazali mohamedelghazali commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Tip

Start the title with a prefix so the PR is labeled automatically: feat: fix: docs: ci: build: i18n:
Example: fix(hwp): keep tables when converting to DOCX

What does this change?

Type of change

  • Bug fix
  • New feature or improvement
  • New format or engine
  • Translation
  • Documentation
  • Build, CI or dependencies

How was it tested?

  • dotnet format --verify-no-changes
  • dotnet test
  • Tried it in the app (what you converted or clicked, and on which OS):

Screenshots (UI changes)

Checklist

  • New UI strings are in all src/Filee.App/Assets/i18n/*.json files
  • New third-party code or binaries are listed in THIRD-PARTY-NOTICES.md
  • The PR does one thing (unrelated changes go in a separate PR)

@KnifeLemon

Copy link
Copy Markdown
Owner

Thanks, @mohamedelghazali. You spotted the cause of #510 before we did: 130% is too tall for Latin fonts. We reached the same conclusion while working through that report, and I'm going with #1137 instead of this PR, for two reasons:

The line height alone also doesn't bring the reporter's file back to one page; spaces were drawn too wide as well (#1136).

I'm closing this one, and #1137 credits you as co-author, since you found this first. Your tests and write-up were clear, so please do pick up something else if you'd like. Anything labelled bug with a sample file attached is a good place to start, and leaving a comment on the issue first lets us avoid overlaps like this one.

@KnifeLemon KnifeLemon closed this Nov 4, 2026
KnifeLemon added a commit that referenced this pull request Nov 4, 2026
#1125 found that 130% is too tall for Latin fonts before this branch did.

Co-Authored-By: Mohamed El Ghazali  <48661966+mohamedelghazali@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mohamedelghazali

Copy link
Copy Markdown
Contributor Author

Thank you for the update and for recognizing my contribution to identifying the root cause.

I understand the decision to close this PR in favor of the more comprehensive solution in #1137. My priority is always to help improve the project, so I'm glad the issue is being addressed with a solution that handles the different font and document scenarios more reliably.

I appreciate the constructive feedback and the acknowledgment. I'll carry these insights into my future contributions to Filee.

Thanks again for your time and guidance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants