Repository navigation
Fix/docx latin line spacing 510 - #1125
mohamedelghazali wants to merge 5 commits into
Conversation
|
Thanks, @mohamedelghazali. You spotted the cause of #510 before we did: 130% is too tall for Latin fonts. We reached the same conclusion while working through that report, and I'm going with #1137 instead of this PR, for two reasons:
The line height alone also doesn't bring the reporter's file back to one page; spaces were drawn too wide as well (#1136). I'm closing this one, and #1137 credits you as co-author, since you found this first. Your tests and write-up were clear, so please do pick up something else if you'd like. Anything labelled |
#1125 found that 130% is too tall for Latin fonts before this branch did. Co-Authored-By: Mohamed El Ghazali <48661966+mohamedelghazali@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thank you for the update and for recognizing my contribution to identifying the root cause. I understand the decision to close this PR in favor of the more comprehensive solution in #1137. My priority is always to help improve the project, so I'm glad the issue is being addressed with a solution that handles the different font and document scenarios more reliably. I appreciate the constructive feedback and the acknowledgment. I'll carry these insights into my future contributions to Filee. Thanks again for your time and guidance! |
Tip
Start the title with a prefix so the PR is labeled automatically:
feat:fix:docs:ci:build:i18n:Example:
fix(hwp): keep tables when converting to DOCXWhat does this change?
Type of change
How was it tested?
dotnet format --verify-no-changesdotnet testScreenshots (UI changes)
Checklist
src/Filee.App/Assets/i18n/*.jsonfilesTHIRD-PARTY-NOTICES.md