Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/tunex/engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,11 @@ def ready(self) -> None:
self._read_until(lambda line: line == "readyok", self.startup_timeout)

def set_option(self, name: str, value: Any) -> None:
# Engines without a UseNNUE option are HCE-only. Do not send an
# unsupported setoption command when NNUE was explicitly disabled.
# Asking to ENABLE NNUE must still fail under strict validation.
if name == "UseNNUE" and "UseNNUE" not in self.options and value is False:
return
if self.strict_options and self.options and name not in self.options:
raise EngineError(f"{self.name} does not advertise UCI option {name!r}")
if value is None:
Expand Down
46 changes: 46 additions & 0 deletions tests/test_optional_usennue.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
from __future__ import annotations

import unittest
from unittest.mock import MagicMock

from tunex.engine import EngineError, UciEngine


class OptionalUseNnueTests(unittest.TestCase):
def make_engine(self, *, strict: bool = True) -> UciEngine:
engine = UciEngine("unused", name="HCE engine", strict_options=strict)
engine.options = {"Hash", "Threads"}
engine.send = MagicMock()
return engine

def test_false_use_nnue_is_ignored_when_unadvertised(self):
engine = self.make_engine()
engine.set_option("UseNNUE", False)
engine.send.assert_not_called()

def test_missing_use_nnue_true_is_rejected(self):
engine = self.make_engine()
with self.assertRaisesRegex(EngineError, "UseNNUE"):
engine.set_option("UseNNUE", True)
engine.send.assert_not_called()

def test_missing_use_nnue_true_still_sent_when_non_strict(self):
engine = self.make_engine(strict=False)
engine.set_option("UseNNUE", True)
engine.send.assert_called_once_with("setoption name UseNNUE value true")

def test_advertised_use_nnue_false_is_sent(self):
engine = self.make_engine()
engine.options.add("UseNNUE")
engine.set_option("UseNNUE", False)
engine.send.assert_called_once_with("setoption name UseNNUE value false")

def test_other_missing_option_still_rejected(self):
engine = self.make_engine()
with self.assertRaisesRegex(EngineError, "UnknownOption"):
engine.set_option("UnknownOption", 1)
engine.send.assert_not_called()


if __name__ == "__main__":
unittest.main()
Loading