fix(databases): show branch names the API accepts and say when a connection string is withheld - #169
Open
subnetmarco wants to merge 1 commit into
Open
fix(databases): show branch names the API accepts and say when a connection string is withheld#169subnetmarco wants to merge 1 commit into
subnetmarco wants to merge 1 commit into
Conversation
…ng is withheld Branch names are lowercase letters, digits and underscores, so every documented example and test fixture named feature-x was a name the API refuses. Anyone copying the docs got a 400 on their first branch. A connection string the platform withholds until a resource is active made --show-connection-string print nothing at all, indistinguishable from a flag that did nothing. Both the database and branch views now say why the line is empty, and a password rotation that comes back without one warns and points at the command that reads it, since that string is the user's only copy of the new credential. A branch whose expires_at is absent rendered as expired in both views, which reads as a branch about to be collected rather than a malformed response. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feature-x, a name the API refuses, so anyone copying the docs got a 400 on their first branch.--show-connection-stringprinted nothing when the platform withholds the string until the resource is active. The database and branch views now say why the line is empty, and a rotation that returns no string warns and points at the command that reads it — that string is the user's only copy of the new credential.expires_atrendered asexpiredin both views, which reads as a branch about to be collected rather than a malformed response.Test plan
make checkgo test ./internal/cmd/databases/... ./internal/output/...volcano cloud databases branches get <db> <branch> --show-connection-stringon a provisioning branch reports the withheld stringMade with Cursor