Skip to content

ci: cancel superseded runs in tests workflow (#2341) - #2374

Merged
AkramBitar merged 1 commit into
LFDT-Panurus:mainfrom
SurbhiAgarwal1:fix/2341-ci-concurrency-cancel-tests
Sep 17, 2026
Merged

AkramBitar merged 1 commit into
LFDT-Panurus:mainfrom
SurbhiAgarwal1:fix/2341-ci-concurrency-cancel-tests

Conversation

@SurbhiAgarwal1

Copy link
Copy Markdown
Contributor

Fixes #2341

Problem

The Tests workflow (.github/workflows/tests.yml) defines no concurrency group. When a PR branch is force-pushed or rebased, previous in-flight runs execute to completion side by side with new runs, wasting runner capacity and delaying feedback on the latest commit.

Solution

  • Added top-level concurrency block to .github/workflows/tests.yml:
    concurrency:
      group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
      cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}

Copilot AI lite review requested due to automatic review settings September 15, 2026 14:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Effi-S Effi-S added enhancement New feature or request ci labels Sep 16, 2026
@Effi-S Effi-S added this to the Q3/26 milestone Sep 16, 2026
@Effi-S
Effi-S self-requested a review September 16, 2026 06:00
@Effi-S
Effi-S force-pushed the fix/2341-ci-concurrency-cancel-tests branch from f7e3b1f to 7ea5220 Compare September 16, 2026 06:00
Comment thread plan.md Outdated
@Effi-S
Effi-S force-pushed the fix/2341-ci-concurrency-cancel-tests branch from 7ea5220 to 15a5fdd Compare September 16, 2026 13:31
Signed-off-by: Surbhi Agarwal <SurbhiAgarwal1@users.noreply.github.com>

ci: add retry logic to install-tools for proxy resilience (LFDT-Panurus#2341)

Signed-off-by: Surbhi Agarwal <SurbhiAgarwal1@users.noreply.github.com>

Signed-off-by: Effi-S <effi.szt@gmail.com>
@Effi-S
Effi-S force-pushed the fix/2341-ci-concurrency-cancel-tests branch from 15a5fdd to c1feff3 Compare September 16, 2026 14:04
@Effi-S

Effi-S commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

@SurbhiAgarwal1,
I changed pr-2341/.github/workflows/tests.yml:23:

cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}

to

cancel-in-progress: ${{ github.event_name == 'pull_request' }}

@Effi-S
Effi-S requested a review from AkramBitar September 17, 2026 05:39
@AkramBitar
AkramBitar merged commit e23e925 into LFDT-Panurus:main Sep 17, 2026
153 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: superseded Tests workflow runs are not cancelled, wasting runner capacity

4 participants