Repository navigation
fix(desktop): tidy the toast's action, stack and timer line - #4201
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The toast's Undo/Open action read as heavy as the message, the collapsed stack showed the text of the cards behind over the front card's top edge, and an inset 1px timer line drained along the foot like a stray underline.
bg-accent/12 text-accent) with the action's icon before its label (Undo ↶, Open ↗, Release page, Restart, Move…), on the same row as a quiet ×. The card stays as tall as its text.docs/design.mdtoast recipe updated.Changelog
Toasts show Undo and Open as a tinted button with an icon, stack without the text behind showing through, and no longer draw a timer line.
Testing
bun run check; compared grey pill, outline, accent text, tint and a fixed two-line height in the mock window with info/success toasts and actions, collapsed and fanned out.