Updates for C23 standard, newer setuptools, supported python versions - #50
Merged
Conversation
billbrod
changed the title
billbrod
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried to build pyrtools on my laptop for the first time in a while and it failed. After fixing two warnings from setuptools that weren't the cause of the failures (about license classifiers and grabbing
bdist_wheelfrom setuptools, not wheel), figured out the problem was with my C compiler: the C23 standard (released in 2023) officially dropped support for the long-deprecated old style function definitions, which the C code was full of.Figured out I could pass
-std=c18to tell gcc to use the older standard, in which case the build would succeed. However, after talking with @WardBrian , figured it wouldn't be too hard to actually update the code to update the old-style definitions, as it largely involves moving the type declarations into the signature. This PR does that (and also fixes the two setuptools warnings)That change to setuptools also requires dropping support for python 3.8, which only has setuptools version 56.0.0 available (71 is now needed). Adds tests, etc for 3.13 and 3.14 as well (to match plenoptic).