Change cibuildwheel build image, setup trusted publisher workflow - #53
Merged
Conversation
billbrod
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our ubuntu build is still failing (see #52). Came across this discussion which suggests the issue is which manylinux image Pillow is currently supporting. Checking out the cibuildwheel docs, it looks like the defaults are more recent images than manylinux2014, which I was specifying. Thus, I've removed my specification of the build image, and hopefully this will work.
I've also updated the deploy.yml action to use a trusted publisher instead of API keys, as that's now the recommended course of action. I also updated the file so that it will publish to test.pypi.org if the action is triggered manually, so I can test it more easily.
EDIT: looks like that fixed it.