GitHub Issue #1391: SignalData file watcher import task to check container permission for resolved path - #1061
Merged
Merged
Conversation
…Root to check for job user ReadPermission in container
labkey-klum
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
https://github.com/LabKey/internal-issues/issues/1391
SignalDataImportTask lets a metadata file's DataFile column name an arbitrary WebDAV path or absolute server path, and previously copied any such file into the trigger's container as long as it fell under some container's pipeline root — with no permission check. This PR adds a ReadPermission gate: the WebDAV branch now calls resource.canRead(job.getUser(), true), and the pipeline-root containment helper (isUnderAnyPipelineRoot → isReadableUnderAnyPipelineRoot) additionally requires root.hasPermission(container, user, ReadPermission.class). It also unifies the two resolution branches so WebDAV-resolved paths go through the containment check too.
Changes