[bot] Fast-forward for 26.3.18 - #989
Merged
Merged
Conversation
#968) - prepend a leading space to the WHERE clause
* `snprc_ehr` and `snprc_genetics` now declare both `mssql` and `pgsql` as supported databases * SNPRC_EHRTest is no longer marked SQL-Server-only * Replaced SQL-Server's `+` operator with the standard `||` across all SNPRC custom queries so display values, labels, and concatenated identifiers render correctly on both dialects. * Swapped SQL-Server-only `charindex` / `len` for the portable `LOCATE` / `LENGTH` in the SND lookup export queries and the demographics/audit-history queries. * Added explicit casts in UNION queries, and in joins/comparisons where SQL Server's implicit conversions previously hid the type mismatch — Postgres' stricter type system would otherwise reject these queries. * HL7 pivot joins - aligned the `lp.ServiceId` vs `obr.PROCEDURE_ID` types across the HL7 pivot queries so the inner joins resolve on Postgres. * Replaced bit-style comparisons (`= 0`) with boolean literals (`= false`), and replaced `truncate` with `FLOOR` in age-range formatting * The four PIVOT queries that previously read their column list dynamically from `BaboonColonyGroups` now use a literal list; the dynamic form fails LabKey query validation against an empty lookup table. Documented in-line as a maintenance trade-off — adding a new colony group now requires touching these queries. * Corrected stale column references in the Tcruzi report view metadata so they match the columns the underlying queries actually return. --------- Co-authored-by: Marty Pradere <martyp@labkey.com>
## Rationale The `_SND Attribute Data` ETL fails on every run that includes a delete at SNPRC with `java.lang.ClassCastException: class java.lang.Long cannot be cast to class java.lang.Integer`. exp 25.005 widened `exp.Object.ObjectId` and `exp.ObjectProperty.ObjectId` to BIGINT, but `AttributeDataTable.UpdateService.deleteRows` still cast the delete key to `Integer`. `TransformTask` builds each delete key from the target table's PK columns, which for this table are `exp.ObjectProperty`'s `ObjectId` and `PropertyId`, so the first row aborts the step. ## Changes - `AttributeDataTable.UpdateService.deleteRows` casts `ObjectId` and `PropertyId` to `Number` rather than `Integer`. - `EventDataTable` declares its injected `exp.Object.ObjectId` column as `JdbcType.BIGINT` instead of `JdbcType.INTEGER`, matching the widened column.
…976) * Drop redundant unique index on snprc_ehr.labwork_services.ServiceId * Bump snprc_ehr schema version 26.001 -> 26.002
labkey-klum
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated automatically.
Approve all matching PRs simultaneously.
Approval will trigger automatic merge.
View all PRs: https://internal.labkey.com/Scrumtime/Backlog/harvest-gitOpenPullRequests.view?branch=26.3_ff_bot_26.3.18