Skip to content

fix: return typed cooldown errors and extend remittance timeout - #1912

Open
juliet-unoyiza wants to merge 1 commit into
LabsCrypt:mainfrom
juliet-unoyiza:fix/issue-1817
Open

juliet-unoyiza wants to merge 1 commit into
LabsCrypt:mainfrom
juliet-unoyiza:fix/issue-1817

Conversation

@juliet-unoyiza

Copy link
Copy Markdown

Issues

Closes #1817
Closes #1816

Summary

  • Replaces the lending-pool withdrawal cooldown panic with the typed PoolError::WithdrawalCooldownActive result and adds regression coverage.
  • Preserves the existing ZeroShares error code for compatibility; the new error uses the next available code.
  • Extends remittance transaction validity from 30 seconds to 300 seconds so users have enough time to review and sign in Freighter.

Validation

  • Focused lending-pool regression test passed: test_immediate_withdraw_returns_error_when_cooldown_active.
  • git diff --check passed.

@juliet-unoyiza

Copy link
Copy Markdown
Author

@blurbeast Implemented both requested fixes in commit f85be79: #1817 now returns a typed withdrawal-cooldown error, and #1816 uses a 300-second transaction timeout. The PR body contains separate closing keywords for both issues.

@juliet-unoyiza

Copy link
Copy Markdown
Author

@blurbeast I resolved the merge conflict with the latest main, preserving the typed cooldown error and 300-second signing timeout, and pushed the update. Please review and merge once the required checks are green.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant