Repository navigation
Conversation
Contributor
Author
|
@K1NGD4VID please review and merge |
…npause-gating-has
Updated remittance history description and corrected formatting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds the missing test coverage for the
RemittanceNFTpause gate.assert_not_pausedgatesrequire_admin_or_authorized_minter,approve_remint,admin_remint, andset_default_burn_threshold, but no test ever calledpause()orunpause(), leaving theContractPaused(error 13) branch and the unpause-restores-operation path unexercised. This is a tests-only change — no pause semantics were modified.Related Issue
Changes
🧪 Pause/Unpause Coverage
[MODIFY]
backend/src/__tests__/adminDisputePagination.test.tsNftError::ContractPausedoncepause()is called.unpause()restores normal operation for the gated entrypoints.Paused/Unpausedevents and onis_paused()transitioning across both directions.[MODIFY]
backend/src/__tests__/adminGovernanceController.test.tsis_paused()state transitions and emittedPaused/Unpausedevents.Verification Results
pause(),mint/update_score/admin_remint/approve_remintfail withNftError::ContractPausedunpause()restores normal operationis_paused()tracks transitions andPaused/Unpausedevents firecargo test+cargo fmt+ clippy clean; CI greenCloses #1148