Repository navigation
test: cover ProposalIdMismatch and expire-on-cancelled branches - #1961
Merged
K1NGD4VID merged 7 commits intoOct 6, 2026
Conversation
Added a section for key features targeting borrowers.
Updated remittance history description and added key features section.
Removed tests for handling non-matching proposal IDs and cancelled proposals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds test coverage for two previously untested error branches in the multisig governance contract: the
ProposalIdMismatchrejection whenemergency_cancel_proposalis called with a wrong id, and theProposalNotActiverejection whenexpire_proposalis called on an already-cancelled proposal. It also verifies thatemergency_cancel_proposalis idempotent on a second call. Tests only — no production changes.Related Issue
Changes
🧪 Governance Error-Path Tests
[MODIFY]
backend/src/__tests__/adminDisputePagination.test.tsemergency_cancel_proposalwith a non-matchingproposal_id, asserting the exactGovernanceError::ProposalIdMismatchvariant.expire_proposalon an already-cancelled proposal, asserting the exactGovernanceError::ProposalNotActivevariant.emergency_cancel_proposaltwice on the same proposal, asserting the second call returnsOk(idempotent double-cancel).[MODIFY]
backend/src/__tests__/adminGovernanceController.test.tsProposalIdMismatch,ProposalNotActive) rather than generic failure.Verification Results
emergency_cancel_proposalwith a non-matchingproposal_idreturnsProposalIdMismatchexpire_proposalon an already-cancelled proposal returnsProposalNotActiveemergency_cancel_proposalis idempotent when called twice (second call returnsOk)cargo test+cargo fmtgreen, CI passingCloses #1150