Repository navigation
docs: add cross-contract error-code reference table - #1967
Open
Mikardo001 wants to merge 2 commits into
Open
Mikardo001 wants to merge 2 commits into
Mikardo001 wants to merge 2 commits into
Conversation
Author
|
@LabsCrypt I've resolved the merge conflicts with All other changes from Merge commit: Could you take another look when you have a moment? Thanks! |
Mikardo001
force-pushed
the
fix/issue-1158-no-cross-contract-error-code-reference-numeric
branch
from
October 6, 2026 11:03
3e836b9 to
3d7b669
Compare
…ss-contract-error-code-reference-numeric Resolves the merge conflicts with main.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a cross-contract error-code reference so that numeric
contracterrorcodes decoded by the backend/indexer are unambiguous. Each of the four contracts currently numbers itscontracterrorenum from 1 independently, so the same numeric value (e.g.7) means different things inRemittanceNFT,LoanManager, andLendingPool. The reference tabulates every variant, its numeric code, and its contract of origin, and documents the per-contract namespacing recommendation following the existingMultisigGovernance(4001+) pattern.Related Issue
Changes
📚 Error-Code Reference
[ADD]
contracts/ERROR_CODES.mdcontracterrorvariant acrossremittance_nft,loan_manager,lending_pool, andmultisig_governance, with numeric code and contract of origin.7=InvalidRepaymentAmount/InvalidAmount/InsufficientLiquidity) and theLendingPoolgap at code8.MultisigGovernance4001+ convention) and calls out that any in-code renumbering would be a breaking change for the backend/indexer.[MODIFY]
contracts/README.mdERROR_CODES.mdreference.🔧 Backend Decode Alignment
[MODIFY]
backend/src/errors/errorCodes.ts[MODIFY]
backend/src/middleware/errorHandler.tsVerification Results
contracts/ERROR_CODES.mdcovers all four contractsMultisigGovernance4001+contracts/README.mdlinks the new docCloses #1158