Skip to content

[4.x] Fixes static analysis #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DarkGhostHunter merged 2 commits into from
Sep 15, 2026
Merged

[4.x] Fixes static analysis #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd9f73d
[4.x] Fixes static analysis
DarkGhostHunter Sep 15, 2026
60e0292
Fixes forward call to the form request, generics.
DarkGhostHunter Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Eloquent/PendingBuilderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,10 @@ public function __get(string $name): static
*/
public function __call(string $name, array $arguments): ExpectationInterface|Expectation|CompositeExpectation|static
{
$this->last = $this->mock->expects($name)->with(...$arguments); // @phpstan-ignore-line
$this->last = $this->mock->expects($name)->with(...$arguments);

if ($this->continue) {
$this->last->andReturnSelf(); // @phpstan-ignore-line
$this->last->andReturnSelf();

return $this;
}
Expand Down
4 changes: 3 additions & 1 deletion src/Http/Requests/PendingTestFormRequest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ class PendingTestFormRequest

/**
* Create a new Pending Test.
*
* @param TForm $formRequest
*/
public function __construct(protected TestCase $testCase, protected FormRequest $formRequest)
{
Expand Down Expand Up @@ -191,6 +193,6 @@ public function assertFormData(array $data): static
*/
public function __call(string $name, array $arguments): mixed
{
return $this->forwardCallTo($this->request, $name, $arguments);
return $this->forwardCallTo($this->formRequest, $name, $arguments);
}
}
13 changes: 13 additions & 0 deletions tests/Http/Requests/InteractsWithFormRequestsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ class InteractsWithFormRequestsTest extends TestCase
{
use InteractsWithFormRequests;

/**
* @var PendingTestFormRequest<TestFormRequest>
*/
protected PendingTestFormRequest $formRequest;

protected function setUp(): void
Expand Down Expand Up @@ -143,6 +146,11 @@ public function test_assert_form_data_fails(): void

$this->formRequest->assertFormData(['foo' => 'quz']);
}

public function test_forwards_call_to_form_request(): void
{
static::assertTrue($this->formRequest->callsFormRequest());
}
}

class TestFormRequest extends FormRequest
Expand All @@ -163,4 +171,9 @@ public function passedValidation(): void
{
$this->request->set('baz', 'quz');
}

public function callsFormRequest(): true
{
return true;
}
}
Loading