Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The credit-based billing flow can return
nextCreditExpiry: "0"for credits that do not expire. The CLI treated that non-empty string as a valid timestamp and displayed December 1969 or January 1970. Separately, wallets with an uninitialized app quota were told to runecloud billing subscribe, which is no longer the correct recovery action.This change:
Validation:
git diff --check: passedBroader repository checks have existing unrelated failures: the CLI-wide TypeScript check reports errors across existing tests and instance-type definitions, and running all billing tests together reports 40 passing tests plus one
subscribe.test.tsmock-call assertion failure. The focused test file passes independently.