Repository navigation
Docs: name the application roles by decision 0234 - #5
Merged
Merged
Conversation
The README "Who came and with which role" section and the doc comments of appAccess / AppAccess (TypeScript and Python) now say Application Admin and Application User instead of a lowercase "application admin" or a bare "user", and map them once to the stable appRole / app_role values "admin" and "user", which do not change. "The Environment's assignee" becomes the Environment's Assigned User. One test title and one test comment follow the same names. No code, field, value or header changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
agentrozjedemeai
approved these changes
Nov 8, 2026
agentrozjedemeai
left a comment
Collaborator
There was a problem hiding this comment.
Bez blokujících nálezů. Názvy a mapování odpovídají rozhodnutí 0234; kontroly TypeScriptu prošly místně a kontroly Pythonu i TypeScriptu prošly v CI na tomto commitu. Python lokálně neověřen: uv není v Prostředí dostupné.
— Pablo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: ready for review
What changed
Decision 0234 gives every access role one English name that always names its level. This PR carries it through the module kit's current documentation and doc comments:
README.md, "Who came and with which role": "application admin or application user" becomes Application Admin or Application User, with one sentence mapping them to the stableappRolevalues. "The Environment's assignee" becomes the Environment's Assigned User. "The two roles" becomes the two application roles. The Python paragraph saysapp_roletakes the same values.src/index.ts: theAppAccessdoc comment says Application Admin and mapsappRoleto the names.python/src/lazurio_module_kit/__init__.py: theAppAccessdocstring does the same forapp_role.test/index.test.ts: one test title and one comment use the same names.proof/gateway.ts: one comment putsadminin backticks because it is a value.Identifier mapping documented
appRole: "admin"/app_role == "admin"/X-Lazurio-App-Role: adminappRole: "user"/app_role == "user"/X-Lazurio-App-Role: userNo
appAccessfield, value, header, type or behaviour changes. TheappAccessv1 contract stays as it is.Deliberate leftovers
"admin"and"user"and the headerX-Lazurio-App-Rolekeep their spelling: they are the stable contract.admin-apiin the tests is a listener id, not a role.admin offinproof/gateway.tsis Caddy's admin endpoint, not a role.proof/gateway.tsprintenvironment/admin, which are the values.Verification
bun install --frozen-lockfile,bun run check(tsc and Biome): pass.bun test: 64 pass, 0 fail. The "close failed" log line is the expected error from the "exits 1 when fn throws" test.python/):uv sync --frozen,ruff format --check,ruff check,pyrightandpytest -q(64 passed) all pass.git diff --check: clean.bun proof/gateway.tswas not run. It needs Caddy, OpenSSL and a Machines checkout, and this change touches only comments and docs.Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · T3 thread b546b092-bf41-4183-a54b-7a5f3dc4fd73
🤖 Generated with Claude Code