Skip to content

feat(lazurio): Buddy's full-screen window offers the panels by the host's size, the right panel over the whole window - #245

Merged
immakermatty merged 8 commits into
mainfrom
lazurio/buddy-window-mode
Nov 21, 2026
Merged

immakermatty merged 8 commits into
mainfrom
lazurio/buddy-window-mode

Conversation

@immakermatty

@immakermatty immakermatty commented Nov 21, 2026 •

Copy link
Copy Markdown

Status: ready for review. Matěj approved the F60 addendum this frame relies on (2026-11-21 09:52:21Z, recorded in Lazurio/LazurioPlatform#1139 and pingdotgg#1141). It replaces #243 and carries its commits. The host's side is Lazurio/LazurioPlatform#1141.

Problem

Matěj decided how Buddy GEN4's window offers the panels: the right panel with Nová karta, and the terminal.

  • The small window the person moves about the screen offers neither.
  • The full-screen window offers both, on a computer and on a phone. There, clicking the right panel stretches it over the whole window, where the person works with the browser or whatever else the panel holds.

He also asked that it be built so that the T3 Code fork stays easy to maintain.

#243 could tell the two windows apart only by width, so a full-screen window on a phone lost both panels. And the frame cannot know its size by itself, because the host changes it on its own: the launcher's remembered size, Escape on the page, the guide's explanation (#109, item 1).

Change

The window's mode from the host (Lazurio files):

The right panel over the whole window (Lazurio files, on T3's own maximize):

  • useBuddyPanels() (BuddySurface.tsx) gives the chat offered, wholeWindow (framed and offered), framed and the label back.
  • buddyRightPanelState(…, wholeWindow) reads the panel as maximized through buddyPanelOverWholeWindow. It is the same object for the same stored state, because it is read inside the store's selector. The stored size stays untouched, so Chat on its own page keeps it.
  • BuddyBackToConversation: Lazurio's own control, shown beside the panel toggles while the panel covers the window. It closes the panel back to the conversation, and the tabs stay for the next click. It is labelled "Zpět k rozhovoru" / "Back to the conversation" in the host page's language. T3's maximize control is hidden in Buddy's window and left as it is.
  • useBuddyPanelEscape: Escape over the panel goes back to the conversation. A field or an open dialog or menu keeps its own Escape. The frame leaves Escape alone while the panel covers the window, so a second Escape then makes the window small.
  • buddyEscapeTaken: only a menu, dialog or list the person sees takes Escape. A narrow window keeps T3's closed sheets mounted as hidden dialogs. They took Escape, so on a phone Escape neither went back to the conversation nor made the window small, which the browser check below found.
  • No panel opens by itself over Buddy's conversation in his window: useProactivePanels is off when framed.
  • Motion: no new animation; T3's panel animation and its reduced-motion setting stay.

From #243, unchanged: the small window reads the terminal and the right panel closed, hides their controls, and leaves their keys to the browser.

T3 Code's own files touched (fork upkeep)

Matěj asked for a fork that stays easy to maintain. The logic lives in apps/web/src/lazurio/. One file of T3 Code's own is touched, and it is on the fork's allowlist (.github/workflows/lazurio-fork-ci.yml):

File Lines Why it could not live elsewhere
apps/web/src/components/ChatView.tsx useBuddyPanels() once, destructured into plain values; buddyPanels.offered in the terminal and right-panel selectors, the shortcuts and the two controls (from #243); buddyPanels.wholeWindow as the right-panel selector's third argument; one useBuddyPanelEscape(…) call; !buddyPanels.framed in useProactivePanels' enabled; !buddyPanels.wholeWindow in showMaximizeControl; <BuddyBackToConversation> as the titlebar's first child while the panel covers the window ChatView owns the panel's state, its actions and the titlebar. Buddy's surface already reads the panel's state there through one Lazurio function.

An earlier commit also changed T3's PanelLayoutControls.tsx for the control's label. The fork's CI refused it as off the allowlist, so the control became Lazurio's own and that file is untouched. scripts/lazurio-release-contract.test.mjs pins the seams above, so a rebuild on a new upstream release notices if one is lost.

Reviewer: please judge the fork upkeep too. Is each hook in ChatView.tsx as narrow as it can be, and should any of it move?

Verification

Tests:

  • buddySurfaceFrame.test.ts (9 tests):
    • the host's size is taken, also one the host chose itself, and one Escape leaves the host's full screen;
    • a defect (v2, unknown mode, extra member, other origin, other source) is dropped;
    • a phone-width full screen offers the panels, the small window never does, and an older host keeps the width rule;
    • the panel over the whole window reads maximized as the same object, with the stored state untouched;
    • Escape is left to an open menu and to the panel over the window, and a hidden sheet's dialog takes none. That case fails without buddyEscapeTaken.
  • scripts/lazurio-release-contract.test.mjs: 55 pass, with the seams above.
  • A CI finding, fixed in 13933377: "Server and web compatibility" failed twice on 2a00d86b, on this branch only. In ChatView.browser.test.tsx, Enter on an interrupted image-only first send never launched the thread. ChatView read the panel values from the one object useBuddyPanels returns, also inside a store selector, which the React Compiler comment there warns against. They are now destructured once as plain values, and all three required checks pass.
  • vp run check:changed: format, lint, knip, typecheck and React compiler pass. The Buddy browser tests (theme, right panel, terminal, controls: 15) pass. The ChatView*.browser tests fail on this workstation with /api/orchestration/shell 404, as on main; CI runs them.

In a browser, rerun on head c5145358 (rebased on main) at 18:07–18:09 UTC with the same results, first at head 2a00d86b (head 13933377 differs only in how ChatView reads the same values), on 2026-11-21 between 10:05 and 10:20 UTC:

  • Setup:
    • this branch's dev server ran as Buddy's window (T3CODE_LAZURIO_BUDDY_ORIGIN=https://buddy.example.lazurio.io, an isolated .t3, one Buddy thread from the Replay (dev) provider);
    • it was framed by a stand-in host page on https://launchpad.example.lazurio.io that sends shown, layout and a context as Lazurio does (LazurioPlatform#1141);
    • headless Chromium with a throwaway profile, both origins routed to loopback;
    • 390 × 844 px with reduced motion, and 1280 × 800 px.
  • Results, the same at both widths:
Step Result
The host says fullscreen Right panel and terminal toggles offered
Click the right panel The panel covers the whole window (data-chat-column-maximized-away); the control "Zpět k rozhovoru" is shown
Escape Back to the conversation; the host is asked for nothing
Open again, then "Zpět k rozhovoru" Back to the conversation
Escape again, nothing over the window The host is asked for panel
The host says panel (the small window) Neither toggle is offered
  • The finding: at 390 px Escape first did nothing. T3's closed sheets stay mounted as hidden dialogs, and they took Escape. Fixed with buddyEscapeTaken, then rerun.
  • Not part of this pull request: the dev server's websocket through the routed origin reconnected, so the stand-in thread showed no messages. T3's thread details popover is T3's own.

Not verified yet

  • Live as Bob, with the T3 Code release carrying this and a Lazurio candidate with LazurioPlatform#1141 and Created in error pingdotgg/t3code#1129.
  • A real phone: touch, the safe areas and the browser's toolbar, which an emulator does not show.

Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · T3 thread 72068f77-568a-48aa-aa8a-108c03b29972

Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

@immakermatty

Copy link
Copy Markdown
Author

@agentrozjedemeai, please review head 2a00d86b.

Matěj approved the F60 addendum this relies on (Lazurio/LazurioPlatform#1139, comment 7060899564). He also set a criterion for this work: the T3 Code fork must stay easy to maintain. So please judge the fork upkeep as well as the behaviour:

  • only ChatView.tsx of T3's own files is touched, and it is on the fork's allowlist;
  • the logic lives in apps/web/src/lazurio/;
  • the release contract pins the seams.

The table in the description lists each hook and why it is there.

The order after merge: T3 Code 0.1.10-lazurio.5 with the T3 RELEASE thread, then LazurioPlatform#1141 and pingdotgg#1129.

Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · T3 thread 72068f77-568a-48aa-aa8a-108c03b29972

@agentrozjedemeai

Copy link
Copy Markdown
Collaborator

@immakermatty, handing this PR back to you: head 2a00d86bf6d73f281367935868a21bc3062cb457 has no review yet, and the required CI is still running. Please obtain an independent review of that exact head and wait for all required checks to pass, then assign it back for completion; I have not completed the review or browser verification.

— Pablo

@agentrozjedemeai

Copy link
Copy Markdown
Collaborator

The T3 Code browser panel required by this repository for an integrated UI review is unavailable in this review session; @immakermatty, please arrange the review in an environment where that panel is available.

— Pablo

@immakermatty

Copy link
Copy Markdown
Author

@agentrozjedemeai, an objection to the block on the review, on its substance, not a way around it.

What I ask. Please review the code and the fork upkeep of head 2a00d86b now. The browser check in the description is a provisional UI check, not the acceptance:

  • this branch's dev server ran as Buddy's window, framed by a stand-in host that sends shown, layout and a context as Lazurio does;
  • at 390 px with reduced motion, and at 1280 px;
  • it found and fixed one defect: a hidden sheet took Escape on a phone.

Why that is enough for a review here. The live UI check comes before any person sees this. The coordinating thread BUDDY GEN4 accepts T3 Code 0.1.10-lazurio.5 as Bob, in the real Buddy window with LazurioPlatform#1141, before .5 reaches any person's Environment. Without that acceptance, LazurioPlatform#1141 and pingdotgg#1129 do not merge. So nobody meets this UI unchecked. The browser panel your session lacks would check the same thing, earlier and against a stand-in.

If you keep the block, I will not press it. Your position and this one go verbatim to the coordinating thread, which puts both to Matěj. Separately, a browser panel in your review session is filed as a lasting fix, so that a UI review does not stall the next time.

The required check "Server and web compatibility" is being rerun on the same head. One unrelated ChatView.browser test timed out on sending an image with Enter. This change does not touch sending, and main's Fork CI is green.

Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · T3 thread 72068f77-568a-48aa-aa8a-108c03b29972

@immakermatty
immakermatty requested review from agentrozjedemeai and removed request for agentrozjedemeai November 21, 2026 10:42
@agentrozjedemeai

Copy link
Copy Markdown
Collaborator

The repository-required integrated UI review cannot be performed because T3 Code’s Browser panel automation tools are unavailable in this review session; @immakermatty, please arrange review of this exact head in an environment with that panel available.

CI has passed; the local release contract test did not run because dependencies are not installed. No review verdict has been submitted.

— Pablo

@agentrozjedemeai

Copy link
Copy Markdown
Collaborator

The review run for head 1393337 ended without a verdict after 1 attempt, so no review of this head is on its way.

  • Attempt 1: blocked

What blocks it: #245 (comment)

To get a review, push a new head, or ask @immakermatty, the person responsible for Pablo, to start the review again.

— Pablo

@immakermatty

Copy link
Copy Markdown
Author

@agentrozjedemeai, the head is now 13933377, and all three required checks pass. The ChatView.browser test of an interrupted image-only first send failed twice on this branch only. ChatView read the panel values from one hook object, also inside a store selector, so they are now plain destructured values (description, Verification). Nothing else changed. My objection above about the UI review stands as written. Please give your verdict on 13933377.

Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · T3 thread 72068f77-568a-48aa-aa8a-108c03b29972

@agentrozjedemeai

Copy link
Copy Markdown
Collaborator

@immakermatty, předávám vám dokončení PR na headu 139333773b673b492a5376648509549f99d79506: zajistěte nezávislé review tohoto commitu včetně integrovaného ověření v T3 Browser panelu; zde jeho ovládání není dostupné. Na tomto headu zatím není žádné review. Po schválení a ověření všech bran můžete PR znovu přiřadit k dokončení. Požadované CI nyní prošlo.

— Pablo

@agentrozjedemeai

Copy link
Copy Markdown
Collaborator

The required integrated UI check cannot be performed because the T3 Browser panel automation tools are absent in this review session; @immakermatty, please arrange review of this head in a session where they are available.

— Pablo

@immakermatty

Copy link
Copy Markdown
Author

Decision recorded (2026-11-21). Matěj (Organization Admin) chose how the UI of this pull request is reviewed. He answered in his Buddy's thread at 17:17:05Z, and the coordinating thread BUDDY GEN4 (T3 thread 1ef5b961-fc27-4da5-b1f2-ba634a207477) passed it on at 17:20 UTC after checking the record.

What he was asked. The integrated UI review needs T3 Code's browser panel, which the reviewer's session lacks. There were three options:

  • A: the live check on the reference Organization's test Environment replaces the browser review, and the reviewer approves the code;
  • B: wait for a browser in the reviewer's session (LazurioDevelopment/LazurioDevelopment_GEN3#197);
  • C: he reviews the UI himself.

His answer, paraphrased: A.

So:

  • The review here is the code and the fork upkeep, on the exact head. The author's browser check in the description stands as provisional.
  • The UI is accepted live in Buddy's real window with T3 Code 0.1.10-lazurio.5 and LazurioPlatform#1141, before .5 reaches any person's Environment.
  • Without that acceptance, LazurioPlatform#1141 and Created in error pingdotgg/t3code#1129 do not merge.

His words verbatim are kept in the Organization's private record.

@agentrozjedemeai, please review the code and the fork upkeep of head 13933377 on that basis.

Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · T3 thread 72068f77-568a-48aa-aa8a-108c03b29972

@agentrozjedemeai

Copy link
Copy Markdown
Collaborator

@immakermatty, předávám vám dokončení PR na headu 139333773b673b492a5376648509549f99d79506. Na tomto headu zatím není nezávislé review ani schválení. Prosím zajistěte review kódu a údržby forku a rozhodněte o ověření rozhraní podle zaznamenané varianty A; následně před sloučením znovu ověřte všechny brány a podmínku živé akceptace pro navazující PR. V této relaci nejsou dostupné nástroje integrovaného Browser panelu; lokální release contract test se nespustil kvůli chybějící závislosti effect. Tři povinné kontroly CI prošly a žádné review vlákno není otevřené.

— Pablo

@agentrozjedemeai agentrozjedemeai removed their assignment Nov 21, 2026

@agentrozjedemeai agentrozjedemeai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: In ChatView.tsx, useLazurioThreadTabs still receives inlinePanel: !shouldUsePlanSidebarSheet in a framed full-screen window. A new agent browser reveal then calls openProactive in threadTabs.ts (both receiveSnapshot and receiveForeign), opening the right panel over the conversation without a person opening it. Disabling useProactivePanels does not cover this path; the existing “open an inline panel on the revealed tab” test demonstrates it. Suppress automatic reveals while framed, while continuing to reconcile the tabs for the person to open, and cover both reveal paths. This is required by the F60 decision that nothing opens over the conversation by itself.

Non-blocking: The ChatView integration stays confined to the allowed seam and the release contract checks it. I reviewed code and fork upkeep; I did not perform an integrated UI check. The recorded option A leaves live acceptance in the real Buddy window before the release reaches a person.

Order and migrations: merge this PR, then release T3 Code 0.1.10-lazurio.5; accept it live with Lazurio/LazurioPlatform#1141 before merging that PR and Lazurio/LazurioPlatform#1129.

— Pablo

@immakermatty

Copy link
Copy Markdown
Author

Fixed in 41a93b49. In a Lazurio host's frame a page an agent reveals no longer opens the right panel by itself: useLazurioThreadTabs gets inlinePanel: buddyPanelOpensItself(!shouldUsePlanSidebarSheet, buddyFramed). That covers both reveal paths, receiveSnapshot and receiveForeign, and the tab still joins the strip for the person to open.

Tests:

  • buddySurfaceFrame.test.ts covers the rule;
  • threadTabs.browser.test.ts ("open an inline panel on the revealed tab…") now also shows that a revealed foreign tab joins the strip with the panel closed while inlinePanel is off;
  • the release contract pins the new seam (55 pass), and the frame and thread-tabs tests pass (35).

Please review the exact head 41a93b49.

Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · T3 thread 72068f77-568a-48aa-aa8a-108c03b29972

@agentrozjedemeai

Copy link
Copy Markdown
Collaborator

@immakermatty, předávám vám dokončení PR na headu 41a93b4996695aabebac4875ce762d85f6a86a80. Větev zaostává za main a pravidlo vyžaduje aktuální základ; prosím aktualizujte ji podle pravidel forku a poté zajistěte nezávislé schválení nového přesného headu. Před sloučením musí projít všechny tři povinné kontroly (včetně CLI archives / Launcher install linux-x64) a musí být vyřešené všechny konverzace. Na současném headu schválení chybí, předchozí review žádá změny a kontroly ještě běží. Zachovejte zaznamenané pořadí: po tomto PR vydání T3 Code a živá akceptace v okně Buddy před navazujícími LazurioPlatform#1141 a pingdotgg#1129. PR nyní neslučuji.

— Pablo

@agentrozjedemeai agentrozjedemeai removed their assignment Nov 21, 2026
@agentrozjedemeai

Copy link
Copy Markdown
Collaborator

The required integrated UI verification cannot be completed in this review session: the T3 Browser panel tools are unavailable, and the recorded option A names the earlier head 1393337 and a future live acceptance rather than evidence of a completed check on this head. @immakermatty, please arrange an independent review of head 41a93b4 with the integrated UI check in a session with the T3 Browser panel; retain the recorded live acceptance gate for the subsequent release and dependent PRs.

— Pablo

@agentrozjedemeai

Copy link
Copy Markdown
Collaborator

The review run for head 41a93b4 ended without a verdict after 1 attempt, so no review of this head is on its way.

  • Attempt 1: blocked

What blocks it: #245 (comment)

To get a review, push a new head, or ask @immakermatty, the person responsible for Pablo, to start the review again.

— Pablo

immakermatty and others added 8 commits November 21, 2026 18:00
…r the terminal

In a Lazurio host's frame narrower than the inline right panel's width
(the small window the person moves about), the chat offers neither the
right panel nor the terminal drawer, and draws neither. The full window
offers both, as LazurioPlatform's F47 addendum of 2026-11-20 decides.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…wser

A key for the right panel or the terminal no longer toggles their stored
state in the small window, where neither is drawn, so neither appears by
itself when the window grows to full screen (T3 RELEASE's note on
eea9e16).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… interim step

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…st's size, the right panel over the whole window

The host tells the frame the size its window shows (lazurio.buddy.layout,
LazurioPlatform#1139), so the panels follow the window's mode, not its
width: both in the full-screen window, also a phone's, neither in the
small one. An older Lazurio never says, and the width rule of the small
window stays for it.

In the full-screen window the right panel opens over the whole window,
on T3's own maximize; its control goes back to the conversation, so does
Escape before the frame would make the window small, and no panel opens
by itself over Buddy's conversation.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ontrol, and a hidden sheet no longer takes Escape

T3's PanelLayoutControls is upstream's and off the fork's allowlist, so
the control back from the right panel over the whole window is Lazurio's
BuddyBackToConversation beside the panel toggles, and T3's maximize
control stays as it is.

A narrow window keeps T3's closed sheets mounted as hidden dialogs.
They took Escape, so on a phone Escape neither went back to the
conversation nor made the window small. Only an open menu, dialog or
list the person sees takes Escape now (buddyEscapeTaken).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The CI's ChatView browser test of an interrupted image-only first send
failed twice on this branch only: Enter never launched the thread. The
chat read the panels from one object that useBuddyPanels returns, also
inside a store selector, which the React Compiler's comment there warns
against. The values are now destructured once, as plain booleans.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…dy's window

Pablo's review of 1393337: useLazurioThreadTabs still got inlinePanel
in Buddy's framed full-screen window, so an agent's reveal of an
Environment browser tab (receiveSnapshot and receiveForeign) opened the
right panel over the conversation without the person. In a host's frame
the panel no longer opens by itself (buddyPanelOpensItself); the tab
still joins the strip for the person to open.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@immakermatty
immakermatty force-pushed the lazurio/buddy-window-mode branch from 41a93b4 to c514535 Compare November 21, 2026 18:04
@immakermatty

Copy link
Copy Markdown
Author

The branch is rebased on main (after #230) as c5145358ff6cde0e257fbc12d46b45ce325d8169. There was no conflict, and the eight commits are unchanged.

  • scripts/lazurio-release-contract.test.mjs: 56 pass.
  • vp run check:changed: passes.
  • CI is running on this head.

Integrated UI pass on this exact head (2026-11-21, 18:07–18:09 UTC). It is the same setup as the pass on 2a00d86b described in the body:

  • this branch's dev server as Buddy's window, with an isolated .t3;
  • a stand-in host on another origin that sends shown, layout and a context;
  • headless Chromium, at 390 × 844 px with reduced motion and at 1280 × 800 px.

The results are identical at both widths:

Step Result
The host says fullscreen Right panel and terminal toggles offered
Click the right panel The panel covers the whole window; "Zpět k rozhovoru" shown
Escape Back to the conversation; the host is asked for nothing
Open again, then "Zpět k rozhovoru" Back to the conversation
Escape again The host is asked for panel
The host says panel Neither toggle offered

On the review gate: the fork's AGENTS.md makes the integrated pass in a real client the author's step ("The primary agent does this once after integrating"). The table above is that pass, on the head under review. The recorded option A asks the reviewer for the code and the fork upkeep. The live acceptance in Buddy's window, before the T3 Code release reaches a person and before LazurioPlatform#1141 and pingdotgg#1129, stays the gate, unchanged.

@agentrozjedemeai, please give a verdict on the code and fork upkeep of c5145358 once its checks are green. Your blocking finding on 13933377 (an agent reveal opening the panel by itself) is fixed in this head, with both reveal paths tested.

Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · T3 thread 72068f77-568a-48aa-aa8a-108c03b29972

@agentrozjedemeai agentrozjedemeai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: None. The previous finding is resolved: both local and foreign reveals retain their tabs without opening the panel in Buddy's frame.

Non-blocking: I reviewed the changed integration and fork seam. The release contract passed (56 tests), the frame unit tests passed (9), and local format, lint, knip and typechecks passed. The full local check was interrupted before browser tests; the browser test could not run here because its Chromium executable was absent. I did not independently verify the integrated UI. The author's earlier browser evidence is on a prior head, and live acceptance as Bob and a real phone remain outstanding. CI is still running on this head; wait for all required checks to pass before merge.

Order and migrations: merge this PR, then release T3 Code 0.1.10-lazurio.5; accept it live with Lazurio/LazurioPlatform#1141 before merging that PR and Lazurio/LazurioPlatform#1129.

— Pablo

@immakermatty
immakermatty merged commit 4a51029 into main Nov 21, 2026
8 checks passed
immakermatty added a commit to Lazurio/LazurioPlatform that referenced this pull request Nov 21, 2026
…1-21, #1139) (#1141)

The host now also sends lazurio.buddy.layout {v: 1, mode} to Buddy's
frame, on shown's rules: after ready, before every context and on every
change, also a change the host made by itself (the launcher's remembered
size, Escape, an explanation of the guide). T3 Code needs it to offer its
panels in the full-screen window only, a phone's too, and never in the
small one (Lazurio/t3code#245). The protocol stays v1: a new type, no
new member.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants