Repository navigation
settings: give the Configuration dialog the available screen (#136) - #140
Merged
Merged
Conversation
The Configuration dialog kept a fixed 740px width and an 86vh cap, so on a large screen most of the window stayed empty while the form, its tabs and the search bar were squeezed together. It now uses min(1180px, 96vw) by 88dvh. Refs #136
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Configuration dialog kept a fixed 740px width and an 86vh height cap, so on a large screen the window stayed mostly empty while the form, its tabs and the search bar were squeezed into the middle. It now uses
min(1180px, 96vw)by88dvh. Small screens are unchanged: 96vw still fits, and the existingmin-width: 0override in the mobile media query still applies.This is the first, smallest slice of #136. The larger part of that request — moving SSH Hosts, Remote Access and Telegram into one Infrastructure group — needs a tab host inside the dialog, because the form is rendered from the config schema while those panels are server-backed state rather than config fields. That is a separate change, not a markup shuffle.
Verification:
node test/responsive-ui.test.jspasses, including a new check that pins the sizing contract.node test/settings-ux.test.jsandnode test/sidebar-ux.test.jspass.npm testends at the same pre-existing failure on unmodifiedmainand on this branch (control run), so this diff adds none.Refs #136