Repository navigation
Docs: the ROCm workflow builds HIP - #412
Merged
Merged
Conversation
copilot-instructions.md and skills/fkl-build-and-test/SKILL.md said that no workflow builds HIP. cmake-linux-rocm-amd64.yml does since the ROCm CI (it builds the CPU targets, with the multithreaded back-end, and the HIP targets with amdclang++ and the strict C++17 flags, and runs the tests on an AMD GPU). Added to the workflow table. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019iTqfS8rWiAyRMrM4uU64n
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.github/copilot-instructions.mdandskills/fkl-build-and-test/SKILL.mdsaid that no workflow builds HIP.cmake-linux-rocm-amd64.ymldoes since the ROCm CI (#403): it builds the CPU targets (with the multithreaded back-end, #406) and the HIP targets withamdclang++and-Werror=c++20-extensions -pedantic-errors -Wno-gnu-anonymous-struct, and runs the tests on an AMD GPU.copilot-instructions.mdgets the ROCm row, its file tree comment lists the ROCm workflow, and the paragraph below the table describes what the ROCm workflow configures and builds instead of "No workflow builds the HIP backend".SKILL.mdlistslinux-rocm-amd64among the workflows and says that it is the one that builds HIP.Documentation only; no code, no workflow change.
🤖 Generated with Claude Code
https://claude.ai/code/session_019iTqfS8rWiAyRMrM4uU64n