Repository navigation
ci(workflows): get image and app versions from latest GitHub releases - #224
Merged
Merged
Conversation
JohnVillalovos
previously requested changes
Oct 20, 2026
JohnVillalovos
left a comment
JohnVillalovos
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @colisee
This looks good. But can it be squashed down to one commit? Or do you want to squash it on the merge?
The build workflows no longer read the VERSION_LB_IMG and VERSION_LB_APP repository variables, which had to be updated by hand after each release. A new get-data job uses the gh CLI to look up the latest releases at run time: - build_image_develop.yml: the image version is the latest release of this repository. - build_image_release.yml: the image version is the latest release of this repository, and the app version is the latest release of librebooking/librebooking. Both workflows now call build_and_publish.yml through the $/ prefix instead of ./. GitHub recommends $/ for reusable workflows in the same repository, and it runs them at the same commit as the calling workflow. After this merges, the VERSION_LB_APP, VERSION_LB_IMG and DOCKER_REPOSITORY repository variables can be deleted. DOCKER_REPOSITORY was already unused.
Collaborator
Author
Yes, I always squash on merge |
JohnVillalovos
changed the title
JohnVillalovos
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build workflows no longer read the VERSION_LB_IMG and VERSION_LB_APP
repository variables, which had to be updated by hand after each release.
A new get-data job uses the gh CLI to look up the latest releases at run
time:
this repository.
this repository, and the app version is the latest release of
librebooking/librebooking.
Both workflows now call build_and_publish.yml through the $/ prefix
instead of ./. GitHub recommends $/ for reusable workflows in the same
repository, and it runs them at the same commit as the calling workflow.
After this merges, the VERSION_LB_APP, VERSION_LB_IMG and
DOCKER_REPOSITORY repository variables can be deleted.
DOCKER_REPOSITORY was already unused.
This PR replaces PR #223 based on @JohnVillalovos technical advice to use the
ghcli instead of an external github action