Repository navigation
🎨 docs: Document the Remaining Theme Appearance Keys - #813
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 99013cc416
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| `interface.theme: clickhouse` changes both color and shape: | ||
|
|
||
| - **Palette.** Every color token is defined in both modes from Click UI's light and dark tokens, so nothing falls back to the LibreChat palette. A few values are moved along their Click UI ramps where the verbatim value missed WCAG AA contrast. | ||
| - **Palette.** Every color token is defined in both modes from Click UI's light and dark tokens, so nothing falls back to the LibreChat palette. Values are Click UI's own, even where a pairing falls below WCAG AA contrast. Users who need more contrast can pick a high-contrast mode, which always uses the built-in accessible palette (see [How the theme is chosen](#how-the-theme-is-chosen)). |
There was a problem hiding this comment.
The page says it describes LibreChat's canary branch, but the checked canary sources still contain the contrast-adjusted ClickHouse palette and none of the newly documented appearance tokens (for example, menuPanelRadius, buttonHeightXs, or chromeBorderAlpha); these changes currently exist only in pending/dev work. Consequently, canary operators are told the opposite palette behavior and any configurations using the new rows are silently logged and ignored. Merge the corresponding LibreChat changes into canary first, or clearly mark this entire update as dev-only.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in b3e6d03: the page no longer claims canary; it opens with the Pending: not yet released callout saying these keys are on dev only (v0.8.8 does not read interface.theme), and the source links point at dev.
📦 Next.js Bundle Analysis for librechat.aiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
📦 Next.js Bundle Analysis for librechat.aiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This branch was successfully deployed
1 participant
Summary
The theme page documented 73 of LibreChat's 103 appearance keys. This adds the other 30 to the Appearance table with what each controls, its default and the role it follows when unset: the popover, menu panel and composer action radii, tooltip padding and text size, tab and Select list sizes, Button padding and the
xs,lg, compact andicon-smsizes, the large field height, icon and checkbox sizes, the 10, 11, 13, 15 and 30px type steps with thetext-3xlleading, inline code weight, the neutral button border opacity, the chrome and inset border alphas, anddestructiveStyle. The accepted values list now covers their bounds (pointer targets at least 24px, icon, checkbox and list height ranges, thefill/softchoice).The ClickHouse section is brought up to date with LibreChat-AI/LibreChat#16821: palette values are Click UI's own even where a pairing falls below WCAG AA (high-contrast modes remain available), and it now describes the hidden decorative borders and soft destructive style. The page also stops saying it describes LibreChat's
canarybranch: these keys and the Click UI palette are ondevonly, so the opening note is the site's "Pending: not yet released" callout and the source links point atdev(the same change as #814, so the two merge cleanly in either order).Change Type
Testing
themeAppearanceProperties(packages/client/src/theme/registry.tson LibreChatdev) has a row in the table: checked with a script over the registry.defaultAppearanceandappearanceValidators(packages/data-provider/src/theme.ts).prettier --checkon the page: clean.Checklist
dev