Sim configs: Vismach reorganisation - #4428
Open
Sigma1912 wants to merge 4 commits into
Open
Conversation
- Also changed the component name to match the file name so the model can actually be loaded into hal
- Deprecate vismach models in 'src/hal/user_comps/vismach
Sigma1912
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #4404
Vismach models are exclusively used in simulation configs in the /configs/sim folder. With few exceptions these files are used by a single config and some models rely on stl data that has to be loaded from the sim config using those models.
Each vismach model has been moved into the sim config that uses it.
The linear- and rotary-delta sim configs have been moved to their own sim folder
A new sim config using the melfagui model has been added to show the use of the recently added 'three21kins' kinematic
README files have been updated
All involved sim configs have been tested and start using the local vismach model files.