Repository navigation
feat: support install package on window git-bash - #485
Conversation
Rebased onto the current master: - upgrade go-fake-runtime to v0.0.5 (DefaultExecer is constructed via NewDefaultExecer, FakeExecer must be used as a pointer in the tests) - drop the obsolete workflow Go version bumps and the accidentally committed test.log
e68e299 to
f76dc12
Compare
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
🟢 Coverage 75.00% diff coverage · -0.02% coverage variation
Metric Results Coverage variation ✅ -0.02% coverage variation Diff coverage ✅ 75.00% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (51c1ebb) 4832 2896 59.93% Head commit (6b8bb45) 4835 (+3) 2897 (+1) 59.92% (-0.02%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#485) 12 9 75.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #485 +/- ##
==========================================
+ Coverage 55.29% 55.38% +0.09%
==========================================
Files 75 75
Lines 4612 4615 +3
==========================================
+ Hits 2550 2556 +6
+ Misses 1895 1890 -5
- Partials 167 169 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LinuxSuRen
left a comment
LinuxSuRen
left a comment
There was a problem hiding this comment.
Rebased the branch onto the current master (it was based on a pre-#492 history, and master uses squash merges, so the old commits could not merge cleanly).
What the rebuild did:
- Kept the functional changes: go-fake-runtime → v0.0.5 (NewDefaultExecer, pointer FakeExecer in tests) and the git-bash /usr/bin install dir on Windows
- Dropped the obsolete workflow Go-version bumps (master is on Go 1.26 now) and the accidentally committed pkg/net/test.log
- Fixed a gosec G301 drift (0755 → 0750) in pkg/net
CI is fully green. Merging is left to the maintainer.
|
Rebased onto the current master (the branch predated the #492/#493/#494 squash merges, so it could not merge cleanly).
All CI checks are green. Merge left to the maintainer. |
No description provided.