Skip to content

fix: respect reduced-motion preferences - #67

Merged
ReenigneArcher merged 1 commit into
masterfrom
codex/fix-reduced-motion
Oct 30, 2026
Merged

ReenigneArcher merged 1 commit into
masterfrom
codex/fix-reduced-motion

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Smooth scrolling and the previous/next navigation and portal-card hover transitions ignored reduced-motion preferences. Enable smooth scrolling and transform transitions only inside prefers-reduced-motion: no-preference, while preserving border-color feedback and the final hover states.

Screenshot

Static appearance is unchanged; motion preferences were verified through computed styles in Chrome.

Issues Fixed or Closed

Addresses all three open css:S9440 findings in Sonar project LizardByte_dockle:

  • AaF7eazLkD13o8NHU77z: smooth scrolling.
  • AaF7eazLkD13o8NHU770: previous/next link transitions.
  • AaF7eazLkD13o8NHU771: portal-card transitions.

Roadmap Issues

Testing

  • git diff --check: passed.
  • uv run --locked --no-sync python -m pytest tests/test_sphinx_theme.py tests/test_theme.py --no-cov -o addopts= -q --tb=short: 45 tests and 10 subtests passed.
  • Headless Chrome with Playwright: verified computed scrolling and transition properties under reduce and no-preference, and preserved final hover transforms for both links and cards. The reduced-motion check fails against origin/master and passes with this change.
  • No permanent test was added for this small CSS change; the browser check exercises the actual media queries and cascade, which the current Python asset tests do not evaluate.
  • Hosted CI and SonarQube Cloud reanalysis are pending.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.17%. Comparing base (6f9e957) to head (983e3a8).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #67   +/-   ##
=======================================
  Coverage   93.17%   93.17%           
=======================================
  Files          12       12           
  Lines        1993     1993           
  Branches       69       69           
=======================================
  Hits         1857     1857           
  Misses        136      136           
Flag Coverage Δ
Linux-python-3.11 92.74% <ø> (ø)
Linux-python-3.14 92.74% <ø> (ø)
Windows-python-3.11 92.90% <ø> (ø)
Windows-python-3.14 92.90% <ø> (ø)
macOS-python-3.11 92.74% <ø> (ø)
macOS-python-3.14 92.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f9e957...983e3a8. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ReenigneArcher
ReenigneArcher merged commit 9df0133 into master Oct 30, 2026
32 checks passed
@ReenigneArcher
ReenigneArcher deleted the codex/fix-reduced-motion branch October 30, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant