Repository navigation
fix: address review findings on the derived refresh, native solver and export - #153
Merged
Merged
Conversation
…d export - derived refresh: take the layer role first, as the recorded inputs do - native solver: forget the fallback state when the data is read again - skip a constraint layer that was removed from the project - skip a damaged parametric fault when a project loads - clear the state of a removed parametric fault and emit model_updated - Model step: changed layers are a to-do, and the text names the real buttons - export: NaN ids have no unit, and the CSV is written with the csv module
lachlangrose
force-pushed
the
fix/review-findings
branch
from
November 1, 2026 06:55
6f0801a to
111fe6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from a code review of the stack (#132 to #148). This PR is on top of #148.
Changes
_needs_inequalitiesis built again on a data refresh.spec_from_dictraisesValueErrorfor a damaged spec. The project load skips that fault and logs it. Removing a fault clears its state and emitsmodel_updated.csvmodule, so a quote in a unit name is escaped.Not changed
summarise_datacounts a row with bothvaland gradient columns twice. Both are real constraints, so this is correct.Tests
tests/qgis) were not run.