Repository navigation
Add the NA nurturing and music score rows missing from the server constants table - #69
Conversation
…stants table The server constants.xml has KR and CN rows for the nurturing keys and no row at all for UgcMarketNewMusicScoreItemID, so an NA server reads 0 for them. Each NA row is copied from the client's Xml/table/constants.xml and placed after that key's existing rows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Server/table/Server/constants.xmlhas KR and CN rows for six nurturing keys and none for NA, and no row at all forUgcMarketNewMusicScoreItemID. A server on NA data therefore found no value for them. This adds the seven NA lines, each copied from the client'sXml/table/constants.xmland placed right after that key's existing rows. No existing line changes.This is the same kind of fix as #64, for keys that PR did not cover because the server did not read them yet. The emulator change that starts reading them, MS2Community/PrivateMaple2#2266, makes the ingest fail when a key it reads has no row, so this needs to merge first.
Behaviour changes worth a look
Shown as the new NA value. Before this, an NA server had no row for any of them.
NurturingEatMaxCountNurturingPlayMaxCountNurturingEatGrowthNurturingPlayGrowthNurturingQuestTagNurturingGhostCatsNurturingPlayMailIdUgcMarketNewMusicScoreItemIDOn a server that reads them, feeding a nurturing cube now grows it by 10, a visitor can play with it 3 times a day, and the UGC market recognises music score 35100035.
Verification
git diff --numstat origin/main...HEADshows 7 added and 0 removed, in this one file, with no line-ending churn.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by CodeRabbit