Skip to content

Add the NA nurturing and music score rows missing from the server constants table - #69

Merged
AngeloTadeucci merged 1 commit into
mainfrom
fix/server-constants-nurturing-musicscore
Nov 16, 2026
Merged

AngeloTadeucci merged 1 commit into
mainfrom
fix/server-constants-nurturing-musicscore

Conversation

@AngeloTadeucci

@AngeloTadeucci AngeloTadeucci commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Server/table/Server/constants.xml has KR and CN rows for six nurturing keys and none for NA, and no row at all for UgcMarketNewMusicScoreItemID. A server on NA data therefore found no value for them. This adds the seven NA lines, each copied from the client's Xml/table/constants.xml and placed right after that key's existing rows. No existing line changes.

This is the same kind of fix as #64, for keys that PR did not cover because the server did not read them yet. The emulator change that starts reading them, MS2Community/PrivateMaple2#2266, makes the ingest fail when a key it reads has no row, so this needs to merge first.

Behaviour changes worth a look

Shown as the new NA value. Before this, an NA server had no row for any of them.

Key NA
NurturingEatMaxCount 0
NurturingPlayMaxCount 3
NurturingEatGrowth 10
NurturingPlayGrowth 10
NurturingQuestTag NurturingGhostCats
NurturingPlayMailId 19101804
UgcMarketNewMusicScoreItemID 35100035

On a server that reads them, feeding a nurturing cube now grows it by 10, a visitor can play with it 3 times a day, and the UGC market recognises music score 35100035.

Verification

  • git diff --numstat origin/main...HEAD shows 7 added and 0 removed, in this one file, with no line-ending churn.
  • Each new line's value matches the client file's NA line for that key, checked with a grep of both files.
  • The emulator ingest on #2266's branch fails without these rows and names exactly the five keys it newly requires. With them it succeeds, and every value reads back from the stored row as above.
  • Not run in game: the nurturing and music score paths.

Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

Summary by CodeRabbit

  • New Features
    • Added North America settings for nurturing event activities, including eat and play limits, growth values, quest tracking, and related mail.
    • Added support for a music score item in the UGC marketplace.

…stants table

The server constants.xml has KR and CN rows for the nurturing keys and no
row at all for UgcMarketNewMusicScoreItemID, so an NA server reads 0 for
them. Each NA row is copied from the client's Xml/table/constants.xml and
placed after that key's existing rows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The server constants table adds NA-specific values for the nurturing event and an item ID for the UGC market music-score feature.

Changes: NA nurturing event constants

Layer / File(s) Summary
Add NA nurturing event constants
Server/table/Server/constants.xml
Adds NA values for the eat and play limits, quest tag, eat and play growth, and play-mail ID. The existing KR and CN settings remain.

UGC market music-score item

Layer / File(s) Summary
Add music-score item ID
Server/table/Server/constants.xml
Adds item ID 35100035 for the UGCMarketMusicScore feature.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: Minimal · up to 8a6de

The change adds NA nurturing and music-score constants to the server table, and the values match the client table. No concrete merge-blocking risk is established. In-game nurturing and music-score paths were not tested.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title states that the PR adds the NA nurturing and music score rows missing from the server constants table. The raw summary confirms that constants.xml gains NA nurturing values (eat and play lim…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title states that the PR adds the NA nurturing and music score rows missing from the server constants table. The raw summary confirms that constants.xml gains NA nurturing values (eat and play limits, quest tag, growth, play-mail ID) and the music-score item ID 35100035 for UGCMarketMusicScore. The title names the main change and both parts of it, so it matches the changeset.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5f0be952-c44a-43c6-8108-b168777f57d7
Commits

Reviewing files that changed from the base of the PR and between 4611db7 and 8a6de39.

Files selected for processing: 1

  • Server/table/Server/constants.xml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@AngeloTadeucci
AngeloTadeucci merged commit a8cdfbc into main Nov 16, 2026
3 checks passed
@AngeloTadeucci
AngeloTadeucci deleted the fix/server-constants-nurturing-musicscore branch November 16, 2026 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant