Skip to content

Ungate item strings whose only variant is tagged for another region - #70

Merged
Zintixx merged 1 commit into
mainfrom
ungate-region-only-item-strings
Nov 18, 2026
Merged

Zintixx merged 1 commit into
mainfrom
ungate-region-only-item-strings

Conversation

@Zintixx

@Zintixx Zintixx commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

About 1,070 items have a name, plural or description only under a key tagged for another region (<id>--CN, <id>-Event-JP, ...). Any client outside that region resolves no string at all, so the item has no name or description. For example, 20300738 (Mini Vitality Elixir (30)) shows blank on NA. This drops the locale from those keys and keeps any feature gate.

Why it is safe for the region the key was tagged for: an ungated key is the fallback a client uses when no key matches its region. A CN client still finds 20300738-- exactly as it found 20300738--CN, because no competing variant exists for these ids.

What changed

  • WeblateConverter/Json/{ko,en,cn,jp}/itemname.json, itemnameplural.json, koritemdescription.json: renamed keys. The rule, applied per file and taken from the ko source template: if every variant of an id carries a non-NA locale and the id has exactly one variant, <id>-<feature>-<locale> becomes <id>-<feature>-. Renamed by exact text substitution in every locale file, so values, formatting and key order are unchanged.
    • itemname: 1,072 ids. itemnameplural: 568. koritemdescription: 1,171.
    • Mostly CN (745 untagged CN names), plus Event/JP, Event/CN, Develop/*, Level60Item/KR and others. The feature half of each key is kept, so feature gating behaves as before.
  • Xml/string/{cn,en,jp,kr}/…: regenerated with json-to-xml-all. Every changed line differs only by a dropped locale="CN|JP|KR", and the line counts match the renames one for one.

Left alone: 20001735 (Event/JP + Event/CN) and 30001446 (MassiveHideAndSeek/JP + /CN). Dropping the locale would collapse two variants onto one key, so which one wins is a human call.

One visible side effect: a KR client will now show these items' ko source text where it previously showed nothing. For CN-origin keys that text is Chinese. These items are not part of KMS2 content anyway.

Before merging: Weblate

Weblate matches units by key, so for Weblate these are new units. The translations travel with them, because the key is renamed in every locale file at once. Their review state (approved, and so on) may come back as plain "translated". To avoid a merge conflict on Weblate's side:

  1. Commit and push any pending Weblate changes for item/itemname, item/itemnameplural and item/koritemdescription, then lock those components.
  2. Merge this PR.
  3. Have Weblate pull (Repository maintenance → Update), check one renamed unit, e.g. 20300738--, then unlock.

Verification

  • verify-all: passes for all 7 locales, with 0 structural and 0 key issues.
  • 20300738 in Xml/string/en/itemname.xml: <key id="20300738" name="Mini Vitality Elixir (30)" class="consume" />.
  • json-to-xml-all on current main also reorders a few lines in en/koradditionaldescription.xml, en/korskilldescription_50/70.xml and jp/koradditionaldescription.xml. That is churn already present on main, not caused by this change, so it is deliberately not included here.

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

Summary by CodeRabbit

  • Content Updates
    • Updated item names and descriptions across Chinese, English, Japanese, and Korean catalogs, covering equipment, consumables, pets, rewards, and other items.
    • Removed locale-specific markers from many catalog entries, while retaining their names and descriptions.
    • Added item names and descriptions for additional entries, including bundles, pets, and event items.

An item whose name, plural or description exists only under a CN, JP or
KR locale key resolves to nothing on any other client, so items such as
20300738 (Mini Vitality Elixir (30)) show without a name on NA. Drop the
locale from those keys and keep any feature gate. Clients of the region
they were tagged for still resolve them, since an ungated key is their
fallback when no key matches their region.

Ids with several region-gated variants (20001735, 30001446) are left
alone: dropping the locale would collapse them onto one key.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request updates item-name and item-description catalogs in JSON and XML across Chinese, English, Japanese, and Korean locales. It removes many locale markers, preserves many existing names and descriptions, and adds or revises some item names, descriptions, and metadata.

Changes: Catalog locale-scope updates

Layer / File(s) Summary
Update catalog records
WeblateConverter/Json/*/*.json, Xml/string/*/*.xml
Item-name and item-description records drop CN, JP, or KR key suffixes or locale attributes. Existing item values and qualifiers are often retained. Some catalogs add consume-item bundles, pet entries, capsule descriptions, badge details, and other item descriptions or metadata.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Bug fix

Suggested reviewers: angelotadeucci

Merge Risk: Low · up to 52eb2

This change makes single-region item names and descriptions resolve for other regions. Two items, 20302766 and 70300168, now show guide text that does not match what the items do. Correct those two guides before or soon after merge; the rest of the change looks consistent.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ast-grep (0.51.1)

WeblateConverter/Json/en/koritemdescription.json

ast-grep skipped this file: it is too large to scan (10846772 bytes)

WeblateConverter/Json/jp/koritemdescription.json

ast-grep skipped this file: it is too large to scan (12849238 bytes)

WeblateConverter/Json/ko/koritemdescription.json

ast-grep skipped this file: it is too large to scan (13129619 bytes)

Checkov (3.3.30)

WeblateConverter/Json/en/koritemdescription.json

Checkov skipped this file: it is too large to scan (10846772 bytes)

WeblateConverter/Json/jp/koritemdescription.json

Checkov skipped this file: it is too large to scan (12849238 bytes)

WeblateConverter/Json/ko/koritemdescription.json

Checkov skipped this file: it is too large to scan (13129619 bytes)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@Zintixx
Zintixx merged commit eea9f21 into main Nov 18, 2026
2 of 3 checks passed
@Zintixx
Zintixx deleted the ungate-region-only-item-strings branch November 18, 2026 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant