Port browser redirect page, boards landing page, and add polls - #53
Merged
nschimme merged 5 commits intoSep 8, 2026
Merged
Conversation
- Created docs/play/browser.md with client-side screen width redirection. - Updated play-mume links to https://docs.mume.org/play-mume/. - Created docs/resources/boards/index.md and updated all board links across the site. - Downloaded mudjc.jpg asset into docs/public/play/mudjc/.
- Ported play browser redirect script to docs/play/browser.md. - Ported boards overview page to docs/resources/boards/index.md and updated all board links. - Updated play-mume links to https://docs.mume.org/play-mume/. - Downloaded mudjc.jpg asset into docs/public/play/mudjc/. - Ported 1995, 1998, and 2000 player questionnaires into Markdown under docs/resources/questionnaires/.
- Port ./player/browser page to docs/play/browser.md with screen-width detection logic - Update play-mume links across client docs to https://docs.mume.org/play-mume/ - Port boards landing page to docs/resources/boards/index.md and clean up links - Port historical MUME player questionnaires (1995, 1998, 2000, 2024) and update navigation - Fetch missing MUDjc screenshot asset into docs/public/play/mudjc/mudjc.jpg
…markdown file - Remove docs/resources/questionnaires/2024-03.md - Update questionnaires index and resources page to link directly to Looker Studio URL
Contributor
Reviewer's GuideThis PR expands the documentation site with local Boards and questionnaire/poll landing pages, ports Flow diagram for responsive browser client redirectflowchart TD
Browser[Browser visits /play/browser] --> Mounted[Vue onMounted]
Mounted --> Width{screen.width <= 700}
Width -->|Yes| Mobile[Redirect to docs.mume.org/play-mume/]
Width -->|No| Desktop[Redirect to docs.mume.org/MMapper/demo]
Mobile --> Fallback[Fallback link if redirect fails]
Desktop --> Fallback
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="docs/.vitepress/config.js" line_range="58" />
<code_context>
{ text: 'Rules', link: 'https://mume.org/rules/' },
{ text: 'Dictionary', link: 'https://mume.org/dictionary/' },
- { text: 'Boards', link: 'https://mume.org/resources/boards/' },
+ { text: 'Boards', link: '/resources/boards/' },
{ text: 'Download', link: 'https://mume.org/download/' },
{ text: 'Restricted', link: 'https://mume.org/restricted/' }
</code_context>
<issue_to_address>
**issue (broader_impact):** These new root-relative URLs ignore VitePress's configured base path. In GitHub Pages preview deployments, where `VITE_BASE` is a path such as `/pr-123/`, the Boards navigation points to the production-root `/resources/boards/` and the newly added page images request `/assets/...`, so the navigation and images return 404.
**Triggers:** When the site is built for a GitHub Pages preview or any deployment with a non-root `VITE_BASE`.
**Suggested fix:** Use `withBase('/resources/boards/')` for the config navigation link and base-aware asset URLs (or VitePress-resolved image paths) in the new Markdown pages.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: docs/.vitepress/config.js:58
| { text: 'Rules', link: 'https://mume.org/rules/' }, | ||
| { text: 'Dictionary', link: 'https://mume.org/dictionary/' }, | ||
| { text: 'Boards', link: 'https://mume.org/resources/boards/' }, | ||
| { text: 'Boards', link: '/resources/boards/' }, |
Contributor
There was a problem hiding this comment.
issue (broader_impact): These new root-relative URLs ignore VitePress's configured base path. In GitHub Pages preview deployments, where VITE_BASE is a path such as /pr-123/, the Boards navigation points to the production-root /resources/boards/ and the newly added page images request /assets/..., so the navigation and images return 404.
Triggers: When the site is built for a GitHub Pages preview or any deployment with a non-root VITE_BASE.
Suggested fix: Use withBase('/resources/boards/') for the config navigation link and base-aware asset URLs (or VitePress-resolved image paths) in the new Markdown pages.
- Address code review comment regarding VitePress VITE_BASE preview paths - Verify site build under custom VITE_BASE environment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Expand the documentation site with browser play routing, a consolidated boards landing page, and historical and current player polls.
New Features:
Bug Fixes:
Enhancements:
Documentation: