Dark Horse does not give CanFly, so it cannot be used to enter Icarus

[Mosch0512]

Problem

The Dark Horse is a flying mount, but OpenMU does not give it Stats.CanFly. A Dark Lord who rides a Dark Horse and wears no cape or wings therefore cannot enter Icarus, although the Dark Horse should let them fly there like the Dinorant and the Fenrir do.

CanFly currently comes from:

• all wings and capes (Wings.cs: "add CanFly Attribute to all wings");
• the Horn of Dinorant (CharacterClassInitialization: CanFly from IsDinorantEquipped);
• the Horn of Fenrir (Pets.cs: (Stats.CanFly, 1.0f, AggregateType.AddRaw)).

The Dark Horse (Pets.cs, item 13/4) only gets IsHorseEquipped, the movement speed and its options, no CanFly:

var darkHorse = this.CreatePet(4, SkillNumber.Earthshake, 1, 1, "Dark Horse", 218, false, false,
    (Stats.IsHorseEquipped, 1, AggregateType.AddRaw),
    (Stats.MovementSpeed, MovementSpeedConstants.HorseOrFenrirMovementSpeed, AggregateType.Maximum),
    (Stats.MovementSpeedUnderwater, MovementSpeedConstants.HorseOrFenrirMovementSpeed, AggregateType.Maximum));

The original client treats the Dark Horse as flight equipment: its Icarus checks (warp, move, and taking off the wings in Icarus) accept the Dinorant, the Dark Horse and the Fenrir. MuMain does the same (flying tag in its item data).

Steps

1. Log in with a Dark Lord that has a Dark Horse equipped and no cape.
2. Warp or move to Icarus.
3. The server refuses: the map requirement CanFly is not met.

Expected

The Dark Horse gives CanFly, like the Fenrir ((Stats.CanFly, 1.0f, AggregateType.AddRaw) in the Dark Horse's power-ups, or a CanFly relationship from IsHorseEquipped like the one from IsDinorantEquipped). Existing databases need an update plugin that adds it.

Related

• Players can take off all flying items while in Icarus #980: taking off the last flying item in Icarus; its description already counts the Dark Horse as a flying mount.