Admin panel: configure all item drops on one page - #987
Merged
Merged
Conversation
Allows to configure all drops on one page: general drop settings, drop chance overview per map, map drop groups (incl. map assignment), monster specific drops, quest and mini game drop groups, item box drops, randomly dropped items and item option chances. Groups can be added, edited and deleted inline. Based on the initial work of #587. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NGrcDosfNzYj4hMQNhfQYP
…p order Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NGrcDosfNzYj4hMQNhfQYP
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NGrcDosfNzYj4hMQNhfQYP
Contributor
|
i love it i will provide a huch spec planning file which is not ready yet but was also about the exact same problem :D |
…second row The overview now shows each monster which is spawned on a map, with the drop groups which actually apply to it (monster groups plus map groups which match its level and monster restriction), instead of summing up all map groups regardless of the monster level. The possible items of a drop group are shown in a separate row below the group, so they are no longer cut off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NGrcDosfNzYj4hMQNhfQYP
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NGrcDosfNzYj4hMQNhfQYP
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NGrcDosfNzYj4hMQNhfQYP
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NGrcDosfNzYj4hMQNhfQYP
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NGrcDosfNzYj4hMQNhfQYP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #587. Adds a new admin panel page, Game configuration → Item Drops (
/edit-item-drops), that brings all drop-related configuration onto one page. It builds on the idea of #587 and is rebased onto current master.Screenshots
Drop chance overview per monster

Monster drops (possible items in the second row)

Item box drops

Page sections
All sections can be collapsed, and one search box at the top filters them all. Save and Discard buttons are at the top and bottom. Leaving the page with unsaved changes asks for confirmation.
ShouldDropMoney,ItemDropDuration(in seconds),MaximumItemOptionLevelDrop,ExcellentItemDropLevelDelta.DefaultDropGeneratordoes: the monster's own groups, plus the map groups whose monster level range and monster restriction match. Destructibles only use their own groups.Monsterrestriction. Groups can be added and deleted.NumberOfMaximumItemDropsand its own groups. Groups can be added, and drops can be added for another monster. Removing a group from a monster also deletes it once nothing else references it.ItemDefinition.DropItems): source item level, min/max item level, money amount, required character level and drop effect, with the possible items in a second row. Groups can be added and removed.DropsFromMonsters,DropLevelandMaximumDropLevelfor every item.AddsRandomly.Implementation notes
Components/ItemDrops:DropItemGroupTable: the inline-editable table used by the group sections.CollapsibleSection: only renders its body when expanded, which keeps the large item list cheap.IListadapters, so the existingMultiLookupFieldcan editPossibleItemsand the map assignment (map.DropItemGroups).Resources.resxin English only.Resources.Designer.cswas updated by hand, since it couldn't be regenerated in this environment.Testing
src/Web/AdminPanelandsrc/Startup; the new files produce no errors and no warnings.Startup -demo(in-memory data) and drove the page with Playwright:🤖 Generated with Claude Code
https://claude.ai/code/session_01NGrcDosfNzYj4hMQNhfQYP