feat: report the installed DeepSeek Harness version on Windows - #249
Open
yujiezhang-ops wants to merge 1 commit into
Open
yujiezhang-ops wants to merge 1 commit into
yujiezhang-ops wants to merge 1 commit into
Conversation
DeepSeek Harness replaces itself through electron-updater, so the version BootAgent installed is not the one on disk. macOS already reads it from the bundle plist; Windows now reads the exe's ProductVersion (0.1.7-rc.2 on a real Windows 11 install) through the same PowerShell query WorkBuddy uses, now shared as windowsProductVersion. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inspectDSHnow fillsStatus.Versionfrom the installed exe'sVersionInfo.ProductVersion. The app self-updates through electron-updater, so the on-disk version is authoritative, the same reasoning the macOS path already applies to the bundle plist.windowsProductVersion(inwindows_verify.go). The path is still passed viaBOOTAGENT_VERSION_PATH, never interpolated into the script, and a leading UTF-8 BOM is stripped.InspectionUnavailable, matching WorkBuddy.dshWindowsCandidatescomment now records that the path was observed on a real install.Verified on a Windows 11 install of 0.1.7-rc.2: the exe reports ProductVersion
0.1.7-rc.2, matching the HKCU uninstall entry's DisplayVersion.Test plan
TestInspectDSHWindowsReportsTheInstalledProductVersion(mocked runner, BOM + CRLF output, path passed via env)TestInspectDSHWindowsLeavesVersionUnsetWhenTheQueryFailsgo test ./internal/desktopappon Windows: same failure set asmain(only the pre-existingTestZCodeMacOSInstallVerifiesDigestBundleIDAndSignature)🤖 Generated with Claude Code