Repository navigation
feat(ci): install Pi from the Kipp package's lockfile in setup-kipp - #189
Merged
Merged
Conversation
setup-kipp now requires kipp.piInstall in the installed Kipp manifest: a relative subdirectory of the package holding package.json and package-lock.json. It installs Pi from them with npm ci into a fresh RUNNER_TEMP directory, checks the binary reports kipp.supportedPiVersion, exports it as KIPP_PI_BIN, and installs Kipp into Pi with that binary. The global install of Pi from the registry is removed, so a Kipp release without kipp.piInstall fails. Use the Kipp release that matches the setup-kipp pin.
Contributor
🛡️ SHA Pinned Actions Report✅ All 31 file(s) passed — actions are allowed and pinned as required. |
pleb
enabled auto-merge
October 7, 2026 09:40
PatrickDinh
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
npm installof Pi from the registry. The package names that directory inkipp.piInstall.kipp.piInstallnow fails the action. Use the Kipp release that matches the setup-kipp pin.KIPP_PI_BIN, and "Install Kipp into Pi" runs that binary.Why
How
kipp.piInstallmust be a relative path that resolves inside the package and holds a regularpackage.jsonandpackage-lock.json, so the manifest cannot point the install elsewhere.RUNNER_TEMPdirectory and installed withnpm ci --ignore-scripts.--min-release-age=0stops a runner's release-age policy from refusing the locked releases.pi --versionmatcheskipp.supportedPiVersion.adhoc-packagesexception this step needed before.