Repository navigation
feat: native github-actions check - #24
Merged
Merged
Conversation
staff0rd
commented
Oct 8, 2026
staff0rd
left a comment
Member
Author
There was a problem hiding this comment.
Code review summary
Findings: 2 (blocker 0, major 1, minor 1, nit 0)
The schema-validation part of the new github-actions check is solid. The vendored schemas resolve from both src/ and dist/, ajv compiles them, and the tests check exact error output. The main risk is the custom GitHub glob translator in githubPathFilter.ts. It does not let **/ match zero directories, so common, valid path filters are reported as dead. Because the check is recommended and runs in verifyx all, this would fail CI on correct workflows. A smaller issue: negated globs are checked against the wrong file set, which lets some negations that exclude nothing go unreported.
Findings
- major:
**/cannot match zero directories, so valid path filters are reported as dead - minor: Each negated glob is checked against all earlier positive matches instead of the files still included
staff0rd
enabled auto-merge
October 8, 2026 03:46
robdmoore
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a recommended
github-actionscheck, run byverifyx alland preselected byverifyx init. It validates workflows and action metadata against vendored SchemaStore schemas and fails triggerpaths/paths-ignoreglobs that match no file. Each problem printsfile:line:coland the failing rule.Why
An invalid
timeout-minuteskey on a composite action step stopped the runner loading the action, and no check caught it. The@action-validator/cliworkaround is stale on npm, POSIX-only and GPL-3.0.How
Validation is ajv against the Apache-2.0 SchemaStore schemas shipped in
schemas/, so it needs no network at runtime.npm run schemas:refreshupdates them. Repos with workflows that break the schema will start failing when they upgrade.