Repository navigation
Add INSERT ... SELECT and ClickHouse insert settings - #12
Merged
Merged
Conversation
select(query) inserts the rows a query or union selects. The selected aliases name the columns, in select order, so positional and named matching agree; the row is checked against the table at the type level (targetCannotTake, missingColumns). Tenant scope is the SELECT's for an untenanted target, and single-tenant for a tenant target only when the read is and each row takes its tenant from a source tenant column or the same param. returning and onConflict work with select as with values. settings(record) writes INSERT ... SETTINGS on ClickHouse; DialectClauses.insertSettings is optional and Postgres refuses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 12 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (12)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Makisuo
added this pull request to stack #13
October 3, 2026 23:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 4 of
design/writes.md, the last insert phase. Stacked on #11 → #10 → #9.What changes
select(query)takes a query or aunionAll. The selected aliases name the columns in select order, so ClickHouse and Postgres agree.suminto a NOT NULL column is rejected, so wrap it incoalesce.returningandonConflict*work withselect;selectandvaluesreplace each other.settings(record)writesINSERT ... SETTINGS name = valueon ClickHouse. New optionalDialectClauses.insertSettings; Postgres refuses with a defect.encodeInsertRows(§7), since no consumer has asked for it.Testing
bun run typecheckandbun run test: 510 unit tests and the doc checks pass.INSERT ... SELECT ... GROUP BYrollup withonConflictDoUpdateandreturning, run twice to check that it accumulates.INSERT ... SELECTandSETTINGS.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.