Skip to content

Chore/rename effect orm - #6

Merged
Makisuo merged 3 commits into
mainfrom
chore/rename-effect-orm
Oct 3, 2026
Merged

Makisuo merged 3 commits into
mainfrom
chore/rename-effect-orm

Conversation

@Makisuo

@Makisuo Makisuo commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Makisuo and others added 3 commits October 3, 2026 16:01
Each UNION ALL branch is now parenthesized on Postgres, where a branch with
its own WITH, ORDER BY or LIMIT was a syntax error. The placeholder gets the
param kind, so float, bool and timestamp params bind with a cast instead of
taking an int8 or text type from their context. The exact-int8 recipe now
reads a bigint too, which PGlite and postgres.js send.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
core-cases.ts runs the shared builder surface (query and union methods,
operators, params) on live ClickHouse and on PGlite, pins the SQL per dialect
in snapshots, and records real differences per target. The coverage manifest
now requires a core case for every shared method and a Postgres case for every
./postgres export, as it already did for the ClickHouse catalog.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Run one builder suite on every dialect; cover the Postgres entry
@Makisuo
Makisuo merged commit f6ed6f0 into main Oct 3, 2026
3 of 4 checks passed
@coderabbitai

coderabbitai Bot commented Oct 3, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3cefe669-3e74-462f-b0c9-5fc0694ba86a
📥 Commits

Reviewing files that changed from the base of the PR and between 26679fc and eb865b4.

⛔ Files ignored due to path filters (1)
  • tests/__snapshots__/core-sql.test.ts.snap is excluded by !**/*.snap
📒 Files selected for processing (17)
  • CHANGELOG.md
  • docs/params-and-compilation.md
  • docs/postgres.md
  • docs/testing.md
  • src/ch/compile.ts
  • src/ch/dialect.test.ts
  • src/ch/dialect.ts
  • src/pg/dialect.ts
  • src/pg/types.ts
  • tests/core-cases.ts
  • tests/core-sql.test.ts
  • tests/core.clickhouse.test.ts
  • tests/core.postgres.test.ts
  • tests/dialect-cases.postgres.ts
  • tests/dialect-coverage.test.ts
  • tests/dialect.postgres.test.ts
  • tests/postgres-support.ts
 _________________________________________
< 💣 Deploying bug fixes in 3... 2... 1... >
 -----------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Makisuo
Makisuo deleted the chore/rename-effect-orm branch October 3, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant