Repository navigation
feat(email): unsubscribe from digest emails without signing in - #1262
Merged
Merged
Maple Review Bot / Maple / review
succeeded
Oct 5, 2026 in 27s
Confidence 5/5 · No issues found
🟢 Confidence 5/5 · safe to merge
The new test pins all three MAPLE_API_BASE_URL branches and env.ts itself is unchanged since the earlier review.
quality 100/100 · no findings · tests covered · risk low
This commit only adds coverage for appUrlsEnv's MAPLE_API_BASE_URL branch inside packages/infra/src/env.test.ts; the env group it tests is unchanged. Safe to merge.
- Test pins
appUrlsEnv's derivedMAPLE_API_BASE_URLfromdomains.api, the provider override, and theapi.maple.devdefault
Fixed since the last review
- ✅
F2 ·appUrlsEnv's newMAPLE_API_BASE_URLbranch is untested
What was checked
- Test can fail: line 146 expects
https://api.eu.maple.devwhile the provider holdshttps://api.example.test, so a missingderivedbranch breaks it - Assertions match
env.ts:121-123:derivedignores the provider (Config.succeed),plainWithDefaultfalls back for absent/blank values
23fc5db · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading