Skip to content

Metrics single-row toolbar, analytics header tabs, and GitHub repo-access crash fix - #1279

Merged
Makisuo merged 4 commits into
mainfrom
feat/metrics-single-toolbar
Oct 6, 2026
Merged

Metrics single-row toolbar, analytics header tabs, and GitHub repo-access crash fix#1279
Makisuo merged 4 commits into
mainfrom
feat/metrics-single-toolbar

fix(github): keep BranchSelector hooks above its early return

65395ab
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review completed Oct 6, 2026 in 9m 22s

Confidence 3/5 · No issues found

🟡 Confidence 3/5 · needs attention
quality 100/100 · no findings · tests missing · risk low

Warning

This review ended early; what follows is what it established.

The pull request hoists BranchSelector's useAsyncAction above its zero-branch early return, fixing the hooks-order crash for repos that sync in with no branches, and folds the metrics/analytics controls into one header row. It reintroduces no risk; the merge is safe.

  • BranchSelector runs useAsyncAction before returning null when repo.branches is empty
  • metrics-summary-cards.tsx is deleted; MetricsTypeFilter replaces it and never disables a type
  • Metrics page renders MetricsBrowseFilters and MetricsViewToggle in the header; analytics tabs moved into titleContent
What was checked
  • git diff --stat from base 49cb661f to head shows only github-integration-card.tsx differing, so the metrics and analytics hunks are already on main
  • sandbox_grep at the head for MetricsSummaryCards finds no remaining importer, so deleting metrics-summary-cards.tsx breaks no call site
  • metrics-type-filter.tsx reads counts via Option.getOrNull(AsyncResult.value(...)) and renders options whenever the summary is null
Files not reviewed (1)

The review ended before it read these diffs, so nothing above vouches for them.

  • apps/web/src/components/metrics/metrics-summary-cards.tsx

65395ab · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

View more details on Maple Review Bot