Skip to content

fix(scripts): clear effect-lint errors breaking CI on main - #1282

Merged
Makisuo merged 1 commit into
mainfrom
fix/main-effect-lint
Oct 7, 2026
Merged

Makisuo merged 1 commit into
mainfrom
fix/main-effect-lint

Conversation

@Makisuo

@Makisuo Makisuo commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

CI on main fails the TypeScript (effect-lint) job on 4 errors from #1280, which blocks the PRD deploy gate.

  • scripts/seed-demo.ts, scripts/seed-demo/make-env.ts, apps/landing/scripts/screenshots/capture.ts: these are CLI entry points, so disable strict-effect-provide on the single top-level Effect.provide.
  • scripts/seed-demo.ts: return yield* the never-succeeding follow loop.

Verified with oxlint -c .oxlintrc.effect.json on the touched files.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the demo seeding command’s follow-up behavior.
  • Chores
    • Updated lint handling for screenshot capture and demo environment generation.

…ripts

The CLI entry points provide their layers once at the top, so the
strict-effect-provide rule is disabled there. The follow loop never
succeeds, so it is returned.
@maple-review-bot

maple-review-bot Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Maple review

Nothing to review

Lint-only cleanup in three CLI scripts: adds oxlint-disable-next-line effecttsgo/strict-effect-provide above the top-level Effect.provide and return yield*s the never-ending follow loop in seed-demo.ts. No runtime behavior changes.

What was checked
  • All three changed files are tooling/scripts, which this review does not cover
  • return yield* at scripts/seed-demo.ts:336 is on an Effect.forever loop, so the function never falls through differently
  • The new disable comments match the repository's existing pattern (e.g. packages/query-engine/src/local.ts:135, apps/cli/src/bin.ts:79)

5710deb · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9596f520-4d79-4976-8ca2-0a24152110cf
📥 Commits

Reviewing files that changed from the base of the PR and between b76a7cd and 5710deb.

📒 Files selected for processing (3)
  • apps/landing/scripts/screenshots/capture.ts
  • scripts/seed-demo.ts
  • scripts/seed-demo/make-env.ts
 ________________________________________________________________________________________________________________________________________
< Use saboteurs to test your testing. Introduce bugs on purpose in a separate copy of the source to verify that testing will catch them. >
 ----------------------------------------------------------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Makisuo
Makisuo merged commit ab59424 into main Oct 7, 2026
36 of 37 checks passed
@Makisuo
Makisuo deleted the fix/main-effect-lint branch October 7, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant