Repository navigation
fix(scripts): clear effect-lint errors breaking CI on main - #1282
Merged
Merged
Conversation
…ripts The CLI entry points provide their layers once at the top, so the strict-effect-provide rule is disabled there. The follow loop never succeeds, so it is returned.
Maple reviewNothing to review Lint-only cleanup in three CLI scripts: adds What was checked
|
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (3)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on main fails the
TypeScript (effect-lint)job on 4 errors from #1280, which blocks the PRD deploy gate.scripts/seed-demo.ts,scripts/seed-demo/make-env.ts,apps/landing/scripts/screenshots/capture.ts: these are CLI entry points, so disablestrict-effect-provideon the single top-levelEffect.provide.scripts/seed-demo.ts:return yield*the never-succeeding follow loop.Verified with
oxlint -c .oxlintrc.effect.jsonon the touched files.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit