Skip to content

Screen galleries on feature pages, captured from the demo world - #1283

Merged
Makisuo merged 4 commits into
mainfrom
feat/landing-feature-galleries
Oct 7, 2026
Merged

Makisuo merged 4 commits into
mainfrom
feat/landing-feature-galleries

fix(seed-demo): reject libpq host overrides in the --reset database URL

7268b05
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 7, 2026 in 1m 30s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge
The only lines added since the last review are two guard clauses in a dev-only seed script; I read the whole reset path around them.
quality 100/100 · no findings · tests not needed · risk low

Seed-gallery landing work, re-reviewed at 7268b05: the only new code is the --reset guard rejecting libpq host/hostaddr/service overrides, and it holds. Safe to merge. The open maple-landing/telemetry errors are failures in the deployed landing telemetry bundle and this change does not address them.

  • seed-demo --reset now rejects ?host=, ?hostaddr= and ?service= in MAPLE_PG_URL before truncating

Production impact

Open errors in the changed files
Issue Service Occurrences File
Error maple-landing 60 scripts/seed-demo/telemetry.ts
Error maple-landing 12 scripts/seed-demo/telemetry.ts
Error maple-landing 11 scripts/seed-demo/telemetry.ts
@maple/web/TracedFetchError maple-web 7 scripts/seed-demo/telemetry.ts
Error maple-landing 4 scripts/seed-demo/telemetry.ts
@maple/web/TracedFetchError maple-web 3 scripts/seed-demo/telemetry.ts
Error maple-landing 3 scripts/seed-demo/telemetry.ts

After this merges, Maple checks whether they stop.

Telemetry this change adds and removes (1)
  • ➕ span name seedDemo.reset · scripts/seed-demo.ts:134
What was checked
  • Guard regex [?&](host|hostaddr|service)= is case-insensitive and anchored to ?/&, so postgres://localhost/maple_screenshots?host=x is rejected
  • ERROR_STATE_TABLES and error_tick_states exist in packages/db/src/schema/errors.ts:184-490, and investigations in packages/db/src/schema/investigations.ts:28
  • --reset still only runs with Option.isNone(previous), so a --resume run never truncates

7268b05 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.