Skip to content

feat(ga4): Google Analytics integration with delta reconciliation - #810

Open
Makisuo wants to merge 54 commits into
mainfrom
worktree-google-analytics-integration
Open

Makisuo wants to merge 54 commits into
mainfrom
worktree-google-analytics-integration

fix(web): give the GA chips real badge tones, and use countLabel

61f33e5
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 6, 2026 in 1m 3s

Confidence 5/5 · No issues found

🟢 Confidence 5/5 · safe to merge
Both changed files only render GA status, and every symbol they call (Badge variants, countLabel, formatRelativeTime, catalogEntry) was read and matches.
quality 100/100 · no findings · tests not needed · risk low

The two files touched since the last review now use real badge tones and countLabel, closing both open findings without adding defects. Safe to merge.

  • google-analytics-integration-card.tsx chips use warn/secondary badge variants
  • Catalog GA status returns warn/ok and countLabel for property counts
  • Catalog entry added with no docsUrl until the docs page exists
  • GA overview derives health from revoked, erroring and unstarted properties

Fixed since the last review

  • ✅ F7 · Badge variant="warning" is not a defined variant, so the chip renders untinted
  • ✅ F8 · Catalog status returns warning and success, neither a CardStatus/Badge variant
What was checked
  • warn and ok are real Badge variants (packages/ui/src/components/ui/badge.tsx:52-53)
  • countLabel(count, singular, plural) exists (packages/ui/src/lib/format.ts:356)
  • A missing docsUrl renders no link (apps/web/src/routes/integrations.tsx:337)

61f33e5 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.