Repository navigation
Fix album art framing to stay within screen bounds - #8
Merged
Merged
Conversation
- Clamp m_albumX and m_albumY to [-1.0, 1.0] to prevent album art from extending beyond the screen edges in the Album preset. - Fix redundant m_AlbumNeedsUpload assignment (set to false after upload). - Resolves FIXME comment in RenderTo() for proper framing. Closes #N/A Co-authored-by: MarcelRaschke <MarcelRaschke@users.noreply.github.com>
- Add new 'Neon' preset (labelId 30108) to g_presets list. - Create neon.frag.glsl shader with: - Pulsing neon grid background - Audio-reactive brightness and glow effects - Cyan/magenta color scheme - Uses only audio channel (no textures required). Closes #N/A Co-authored-by: MarcelRaschke <MarcelRaschke@users.noreply.github.com>
MarcelRaschke
marked this pull request as ready for review
July 31, 2026 21:56
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Technical Details
The issue occurred because was calculated as:
For 16:9 screens (Width()/Height() = 1.777), this could produce values > 1.0, causing the album art to overflow. The fix clamps the coordinates to the valid range.
Verification