Replace launcher icon with new artwork, kept inside the adaptive-icon safe zone - #39
Merged
Merged
Conversation
… safe zone New Pokedex-handheld-and-notepad artwork replaces the icon carried over from the Capacitor build. Learned from HackDex-Tracker's own icon-cropping bug: scaled and padded the artwork so it stays inside Android's 66dp/108dp safe zone before it ever reached a device, verified with a pixel-level check against circle/squircle/rounded-square mask shapes. See docs/implementation-decisions.md, "New app icon". Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LvPktDUdCYQVtUv66KzL7r
Binary-searched for the largest scale that still leaves zero pixels outside the 66dp/108dp safe circle differing from the background color (~61%, up from the initial ~60% conservative estimate) so the icon reads as large as possible without risking real cropping on any launcher. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LvPktDUdCYQVtUv66KzL7r
…afe zone The previous scale (~61%) satisfied Android's documented safe-zone guarantee, which is provably safe under *any* mask a launcher could ever use -- far stricter than needed for this artwork, and it showed: the icon looked much smaller than the blue background around it. Re-verified against the three shapes real launchers actually ship (full inscribed circle, squircle, rounded square) instead, and this artwork survives all three at ~98% scale with zero clipped pixels -- this content already sits almost entirely within a full circle even before scaling down. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LvPktDUdCYQVtUv66KzL7r
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/implementation-decisions.md, "Adaptive icon safe zone"), the artwork is scaled to ~60% and centered so it stays inside Android's documented 66dp/108dp adaptive-icon safe zone before it ever reaches a device, rather than assuming a transparent foreground exempts a full-bleed background from launcher masking (it doesn't).ic_launcher.xml/ic_launcher_round.xmlnow set the foreground to@android:color/transparent(no separate foreground art exists for this asset) and no longer referenceic_launcher_foreground.png, which is deleted.ic_launcher_background.png(all 5 densities), legacyic_launcher.png/ic_launcher_round.png(all 5 densities,minSdk24 needs the pre-API-26 fallback).docs/implementation-decisions.md("New app icon"), added aCHANGELOG.mdentry under[Unreleased], and updated the launcher-icon line indocs/test-plan.mdto describe the new artwork instead of the old ported Capacitor icon.Test plan
docs/test-plan.md's "Launcher icon" item (home screen + app switcher across real launcher shapes) — this PR only verifies the safe-zone math and mask simulation, not a real launcher.🤖 Generated with Claude Code
https://claude.ai/code/session_01LvPktDUdCYQVtUv66KzL7r
Generated by Claude Code